jenkins-bot has submitted this change and it was merged.
Change subject: Restore config file permissions check
......................................................................
Restore config file permissions check
This was identified in the code review, but not fixed later.
https://www.mediawiki.org/wiki/Special:Code/pywikipedia/10285
Change-Id: I883272185f1e7b2b90dd29dfdbc90637148f4ad5
---
M pywikibot/config2.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/config2.py b/pywikibot/config2.py
index 7193aef..9a0efc0 100644
--- a/pywikibot/config2.py
+++ b/pywikibot/config2.py
@@ -686,7 +686,7 @@
_filemode = _filestatus[0]
_fileuid = _filestatus[4]
if sys.platform == 'win32' or _fileuid in [os.getuid(), 0]:
- if sys.platform == 'win32' or _filemode & 0o02 == 0 or True:
+ if sys.platform == 'win32' or _filemode & 0o02 == 0:
exec(compile(open(_filename).read(), _filename, 'exec'))
else:
print("WARNING: Skipped '%(fn)s': writeable by
others."
--
To view, visit
https://gerrit.wikimedia.org/r/141390
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I883272185f1e7b2b90dd29dfdbc90637148f4ad5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>