jenkins-bot has submitted this change and it was merged. Change subject: [bugfix] delete_dummy must fetch 'quit' parameter ...................................................................... [bugfix] delete_dummy must fetch 'quit' parameter - 'quit' parameter was introduced in 151482c90f16e86 but tests did not recognize it. This patch solves that problem. Bug: T133157 Change-Id: I0162dab5a4de797d18b964948411f1afc94ade9b --- M tests/deletionbot_tests.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/deletionbot_tests.py b/tests/deletionbot_tests.py index 39b4c59..2c170aa 100644 --- a/tests/deletionbot_tests.py +++ b/tests/deletionbot_tests.py @@ -107,14 +107,16 @@ def test_dry(self): """Test dry run of bot.""" delete.main('-page:Main Page', '-always', '-summary:foo') - self.assertEqual(self.delete_args, ['[[Main Page]]', 'foo', False, True]) + self.assertEqual(self.delete_args, ['[[Main Page]]', 'foo', False, + True, True]) delete.main('-page:FoooOoOooO', '-always', '-summary:foo', '-undelete') self.assertEqual(self.undelete_args, ['[[FoooOoOooO]]', 'foo']) -def delete_dummy(self, reason, prompt, mark): +def delete_dummy(self, reason, prompt, mark, quit): """Dummy delete method.""" - TestDeletionBot.delete_args = [self.title(asLink=True), reason, prompt, mark] + TestDeletionBot.delete_args = [self.title(asLink=True), reason, prompt, + mark, quit] def undelete_dummy(self, reason): -- To view, visit https://gerrit.wikimedia.org/r/284470 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0162dab5a4de797d18b964948411f1afc94ade9b Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Mpaa &lt;mpaa.wiki(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>