jenkins-bot has submitted this change and it was merged.
Change subject: Bug 71538 - Pages might not be returned at first req.submit()
......................................................................
Bug 71538 - Pages might not be returned at first req.submit()
Query.Generator returns if self.resultkey is not found in the first
batch of retrieved data.
If "query-continue" is present, valid data might be returned later, so
the query must continue.
Change-Id: I5aa1979d5c7f5c7da74686d91162ecad669a83cf
---
M pywikibot/data/api.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py
index ea68c39..63e47cb 100644
--- a/pywikibot/data/api.py
+++ b/pywikibot/data/api.py
@@ -962,8 +962,11 @@
if self.limit and self.limit > 0 and count >= self.limit:
return
else:
- # No results.
- return
+ # if query-continue is present, self.resultkey might not have been
+ # fetched yet
+ if "query-continue" not in self.data:
+ # No results.
+ return
if self.module == "random" and self.limit:
# "random" module does not return "query-continue"
# now we loop for a new random query
--
To view, visit
https://gerrit.wikimedia.org/r/164258
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5aa1979d5c7f5c7da74686d91162ecad669a83cf
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: jenkins-bot <>