jenkins-bot has submitted this change and it was merged.
Change subject: (bug 55160) Page._getVersionHistory returns only a part of a history
......................................................................
(bug 55160) Page._getVersionHistory returns only a part of a history
https://bugzilla.wikimedia.org/show_bug.cgi?id=55160
Change-Id: I27db336c1853fe5ac9a9c0d8097b870fca2be1ca
---
M wikipedia.py
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia.py b/wikipedia.py
index e14e825..86d4f23 100644
--- a/wikipedia.py
+++ b/wikipedia.py
@@ -3249,9 +3249,18 @@
elif 'invalid' in pageInfo:
raise BadTitle('BadTitle: %s' % self)
- if 'query-continue' in result and getAll:
+ if 'query-continue' in result:
params.update(result['query-continue']['revisions'])
else:
+ thisHistoryDone = True
+
+ if revCount > 0:
+ avail_revs = len(pageInfo['revisions'])
+ pageInfo['revisions'] =
pageInfo['revisions'][:min(revCount, avail_revs)]
+ if not getAll:
+ revCount = revCount - avail_revs
+ else:
+ pageInfo['revisions'] = []
thisHistoryDone = True
if skipFirst:
@@ -3277,9 +3286,7 @@
elements = params['rvprop'].split('|')
row = [values[e] for e in elements]
dataQ.append(tuple(row))
- if
len(result['query']['pages'].values()[0]['revisions']
- ) < revCount:
- thisHistoryDone = True
+
return dataQ
def _getVersionHistoryOld(self, getAll=False, skipFirst=False,
--
To view, visit
https://gerrit.wikimedia.org/r/105619
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27db336c1853fe5ac9a9c0d8097b870fca2be1ca
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>