jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/508506 )
Change subject: [IMPR] Change parseNewUserLog method to generator property
......................................................................
[IMPR] Change parseNewUserLog method to generator property
This generator can be used easily if WelcomeBot derives from BaseBot later.
detached from Iff53f38
Change-Id: I9694052196be5cb8b38a12aba27454008e052781
---
M scripts/welcome.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/welcome.py b/scripts/welcome.py
index 045bc58..9f1b004 100755
--- a/scripts/welcome.py
+++ b/scripts/welcome.py
@@ -718,7 +718,8 @@
break
return True
- def parseNewUserLog(self):
+ @property
+ def generator(self):
"""Retrieve new users."""
if globalvar.timeoffset != 0:
start = self.site.server_time() - timedelta(
@@ -816,7 +817,7 @@
"""Run the bot."""
while True:
welcomed_count = 0
- for users in self.parseNewUserLog():
+ for users in self.generator:
if self.skip_page(users):
continue
--
To view, visit
https://gerrit.wikimedia.org/r/508506
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9694052196be5cb8b38a12aba27454008e052781
Gerrit-Change-Number: 508506
Gerrit-PatchSet: 3
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Lokal Profil <andre.costa(a)wikimedia.se>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot (75)