jenkins-bot has submitted this change and it was merged.
Change subject: Namespace filtering in template.py
......................................................................
Namespace filtering in template.py
The namespace filtering (-namespace, -ns) was broken in core for
template.py, leading to changes intended for one (or more) namespace(s)
bleeding into others.
This commit makes sure that the page generator is always decorated with
genFactory.getCombinedGenerator.
Bug: 67435
Change-Id: I2336ebec356fb87e487f6d266e3415dbca77a603
---
M scripts/template.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/template.py b/scripts/template.py
index 67c2bd0..3730b17 100755
--- a/scripts/template.py
+++ b/scripts/template.py
@@ -371,6 +371,11 @@
gen = pagegenerators.DuplicateFilterPageGenerator(gen)
if user:
gen = UserEditFilterGenerator(gen, user, timestamp, skip)
+
+ if not genFactory.gens:
+ # make sure that proper namespace filtering etc. is handled
+ gen = genFactory.getCombinedGenerator(gen)
+
preloadingGen = pagegenerators.PreloadingGenerator(gen)
bot = TemplateRobot(preloadingGen, templates, subst, remove, editSummary,
--
To view, visit
https://gerrit.wikimedia.org/r/150568
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2336ebec356fb87e487f6d266e3415dbca77a603
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Bep <bjorn.erik.pedersen(a)gmail.com>
Gerrit-Reviewer: Bep <bjorn.erik.pedersen(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>