jenkins-bot has submitted this change and it was merged.
Change subject: [IMPROV] tests: Try to determine source of fails
......................................................................
[IMPROV] tests: Try to determine source of fails
In recent builds there have been some failures on Travis related to the
fact that an apparent subset is not a subset. It tries to solve T92856.
Change-Id: I210f340b392bb7b2ba1ecf640ab9b9176beb2220
---
M tests/site_tests.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 3d116e7..762f91f 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -366,8 +366,11 @@
for pl in links:
self.assertIsInstance(pl, pywikibot.Page)
# test links arguments
- self.assertTrue(links.issuperset(
- set(mysite.pagelinks(mainpage, namespaces=[0, 1]))))
+ # TODO: There have been build failures because the following assertion
+ # wasn't true. Bug: T92856
+ # Example:
https://travis-ci.org/wikimedia/pywikibot-core/jobs/54552081#L505
+ self.assertCountEqual(
+ set(mysite.pagelinks(mainpage, namespaces=[0, 1])) - links, [])
for target in mysite.preloadpages(mysite.pagelinks(mainpage,
follow_redirects=True,
total=5)):
--
To view, visit
https://gerrit.wikimedia.org/r/197089
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I210f340b392bb7b2ba1ecf640ab9b9176beb2220
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>