jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364976 )
Change subject: [bugfix] Fix ResourceWarning in wikimedia_sites.py with python3
......................................................................
[bugfix] Fix ResourceWarning in wikimedia_sites.py with python3
Bug: T166459
Change-Id: I8933eac547a02da14fd06e27e8c900d5c330680b
---
M scripts/maintenance/wikimedia_sites.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/maintenance/wikimedia_sites.py
b/scripts/maintenance/wikimedia_sites.py
index 38054ab..df3ac6a 100755
--- a/scripts/maintenance/wikimedia_sites.py
+++ b/scripts/maintenance/wikimedia_sites.py
@@ -83,8 +83,8 @@
text += u' ]'
pywikibot.output(text)
family_file_name = 'pywikibot/families/%s_family.py' % family
- family_file = codecs.open(family_file_name, 'r', 'utf8')
- family_text = family_file.read()
+ with codecs.open(family_file_name, 'r', 'utf8') as
family_file:
+ family_text = family_file.read()
family_text = re.sub(r'(?msu)^ {8}self.languages_by_size.+?\]',
text, family_text)
with codecs.open(family_file_name, 'w', 'utf8') as
family_file:
--
To view, visit
https://gerrit.wikimedia.org/r/364976
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8933eac547a02da14fd06e27e8c900d5c330680b
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>