jenkins-bot merged this change.

View Change

Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified
[cleanup] Remove unused keyword argument feed

Make feed parameter "feed" in run() method mandatory

detached from I4ef9009c91e

Change-Id: I0dbfd5f1ab34713a1074675ce6e7f9d5f84b53e4
---
M scripts/patrol.py
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/scripts/patrol.py b/scripts/patrol.py
index cbbcec5..7224d62 100755
--- a/scripts/patrol.py
+++ b/scripts/patrol.py
@@ -87,7 +87,6 @@
"""
Initializer.

- @kwarg feed: The changes feed to work on (Newpages or Recentchanges)
@kwarg ask: If True, confirm each patrol action
@kwarg whitelist: page title for whitelist (optional)
@kwarg autopatroluserns: Takes user consent to automatically patrol
@@ -95,7 +94,6 @@
"""
self.availableOptions.update({
'ask': False,
- 'feed': None,
'whitelist': None,
'versionchecktime': 300,
'autopatroluserns': False
@@ -296,12 +294,10 @@
pywikibot.output('Found author ' + author_page_name)
return True

- def run(self, feed=None):
+ def run(self, feed):
"""Process 'whitelist' page absent in generator."""
if self.whitelist is None:
self.load_whitelist()
- if not feed:
- feed = self.getOption('feed')
try:
for page in feed:
self.treat(page)

To view, visit change 462518. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dbfd5f1ab34713a1074675ce6e7f9d5f84b53e4
Gerrit-Change-Number: 462518
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info@gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki@gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: jenkins-bot (75)