jenkins-bot merged this change.

View Change

proofreadpage.py: anticipate page filtering

Anticipate filtering on quality value and page existence,
in order to remove not-interesting pages earlier in the pipeline.

Change-Id: I08d5cd28a8470709c06a47686bb50cea8273c743
---
M pywikibot/proofreadpage.py
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py
index 70304f1..348f67e 100644
--- a/pywikibot/proofreadpage.py
+++ b/pywikibot/proofreadpage.py
@@ -870,16 +870,16 @@
         gen = (self.get_page(i) for i in range(start, end + 1))
         if content:
             gen = self.site.preloadpages(gen)
-        # Decorate and sort by page number because preloadpages does not
-        # guarantee order.
-        # TODO: remove if preloadpages will guarantee order.
-        gen = ((p, self.get_number(p)) for p in gen)
-        gen = (p[0] for p in sorted(gen, key=lambda x: x[1]))
         # Filter by QL.
         gen = (p for p in gen if p.ql in filter_ql)
         # Yield only existing.
         if only_existing:
             gen = (p for p in gen if p.exists())
+        # Decorate and sort by page number because preloadpages does not
+        # guarantee order.
+        # TODO: remove if preloadpages will guarantee order.
+        gen = ((p, self.get_number(p)) for p in gen)
+        gen = (p[0] for p in sorted(gen, key=lambda x: x[1]))
 
         return gen
 

To view, visit change 448859. To unsubscribe, or for help writing mail filters, visit settings.