Pywikibot-commits January 2023

pywikibot-commits@lists.wikimedia.org

1 participants
84 discussions

[Gerrit] ...i18n[master]: fix category-clean message

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/871919 ) Change subject: fix category-clean message ...................................................................... fix category-clean message The meaning of the message is: Remove specified category from the page (or remove page from the category), because the page already belongs to subcategory of specified category `child` Change-Id: I5ea5c5b488e43564bad1b8d1061fcf2f0791c1d0 --- M category/en.json 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/category/en.json b/category/en.json index 207314a..190f45b 100644 --- a/category/en.json +++ b/category/en.json @@ -8,7 +8,7 @@ }, "category-adding": "Bot: Adding category [[:Category:%(newcat)s|%(newcat)s]]", "category-also-in": "(also in %(alsocat)s)", - "category-clean": "Bot: Removing category %(category)s which is already in %(child)s", + "category-clean": "Bot: Removing category %(category)s because it's already under %(child)s", "category-listifying": "Bot: Listifying from %(fromcat)s ({{PLURAL:%(num)d|1 entry|%(num)d entries}})", "category-removing": "Bot: Removing from %(oldcat)s", "category-renamed": "Bot: Moved from %(oldcat)s. Authors: %(authors)s", -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/i18n/+/871919 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/i18n Gerrit-Branch: master Gerrit-Change-Id: I5ea5c5b488e43564bad1b8d1061fcf2f0791c1d0 Gerrit-Change-Number: 871919 Gerrit-PatchSet: 2 Gerrit-Owner: Costa Shul <constantine.shulyupin(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year, 4 months

[Gerrit] ...core[master]: CategoryListifyRobot: refactor `prefix`

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/873037 ) Change subject: CategoryListifyRobot: refactor `prefix` ...................................................................... CategoryListifyRobot: refactor `prefix` use options and kwargs, reduce number of function arguments to make code more generic and clean Change-Id: Ib067a6366a13dd29ad721105f5a4b7938ba9bd2e --- M scripts/category.py 1 file changed, 18 insertions(+), 7 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/category.py b/scripts/category.py index 6923a4a..9046ce2 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -982,8 +982,8 @@ show_images: bool = False, *, talk_pages: bool = False, recurse: Union[int, bool] = False, - prefix: str = '*', - namespaces=None) -> None: + namespaces=None, + **kwargs) -> None: """Initializer.""" self.edit_summary = edit_summary self.append = append @@ -1000,7 +1000,7 @@ self.list = pywikibot.Page(self.site, list_title) self.talk_pages = talk_pages self.recurse = recurse - self.prefix = prefix + self.prefix = kwargs.pop('prefix', '*') self.namespaces = self.site.namespaces.resolve(namespaces or []) self.subcats = not self.namespaces or 'Category' in self.namespaces @@ -1510,7 +1510,6 @@ move_together = False keep_sortkey = None depth = 5 - prefix = '*' # Process global args and prepare generator args parser local_args = pywikibot.handle_args(args) @@ -1585,7 +1584,7 @@ elif option == 'keepsortkey': keep_sortkey = True elif option == 'prefix': - prefix = value + options[option] = value elif option == 'always': options[option] = True else: @@ -1669,8 +1668,8 @@ append, overwrite, showimages, talk_pages=talkpages, recurse=options.get('recurse', False), - prefix=prefix, - namespaces=gen_factory.namespaces) + namespaces=gen_factory.namespaces, + **options) elif action == 'clean': bot = CleanBot(**options) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/873037 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib067a6366a13dd29ad721105f5a4b7938ba9bd2e Gerrit-Change-Number: 873037 Gerrit-PatchSet: 2 Gerrit-Owner: Costa Shul <constantine.shulyupin(a)gmail.com> Gerrit-Reviewer: D3r1ck01 <xsavitar.wiki(a)aol.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year, 4 months

[Gerrit] ...core[master]: [IMPR] Deprecate Timestamp.clone() method

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/871888 ) Change subject: [IMPR] Deprecate Timestamp.clone() method ...................................................................... [IMPR] Deprecate Timestamp.clone() method - Timestamp.clone was introduced to unnecessaryly call replace() method with microseconds parameter but replace() already uses self.microseconds if this parameter was not given (refer Python's documentation). Deprecate this method and use relace() method instead. - remove test_clone() test method. clone() is an alias for replace() now and it is not necessary to test the Python library. Change-Id: Idbb52a6f9336b8bb194a45c70fc92eb322a552ff --- M tests/time_tests.py M pywikibot/time.py 2 files changed, 30 insertions(+), 16 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/time.py b/pywikibot/time.py index 42d8294..d02d53f 100644 --- a/pywikibot/time.py +++ b/pywikibot/time.py @@ -3,7 +3,7 @@ .. versionadded:: 7.5 """ # -# (C) Pywikibot team, 2007-2022 +# (C) Pywikibot team, 2007-2023 # # Distributed under the terms of the MIT license. # @@ -16,7 +16,7 @@ import pywikibot from pywikibot.backports import Tuple -from pywikibot.tools import classproperty +from pywikibot.tools import classproperty, deprecated __all__ = ( @@ -211,9 +211,14 @@ raise ValueError(f'time data {timestr!r} does not match any format.') + @deprecated('replace method', since='8.0.0') def clone(self) -> 'Timestamp': - """Clone this instance.""" - return self.replace(microsecond=self.microsecond) + """Clone this instance. + + .. deprecated:: 8.0 + Use :meth:`replace` method instead. + """ + return self.replace() @classproperty def ISO8601Format(cls: Type['Timestamp']) -> str: # noqa: N802 @@ -244,9 +249,9 @@ # If inadvertently passed a Timestamp object, use replace() # to create a clone. if isinstance(ts, cls): - return ts.clone() - _ts = f'{ts[:10]}{sep}{ts[11:]}' - return cls._from_iso8601(_ts) + return ts.replace() + + return cls._from_iso8601(f'{ts[:10]}{sep}{ts[11:]}') @classmethod def fromtimestampformat(cls: Type['Timestamp'], @@ -282,7 +287,7 @@ # If inadvertently passed a Timestamp object, use replace() # to create a clone. if isinstance(ts, cls): - return ts.clone() + return ts.replace() if len(ts) == 8 and not strict: # year, month and day are given only diff --git a/tests/time_tests.py b/tests/time_tests.py index 7d4f8d8..c074b7e 100755 --- a/tests/time_tests.py +++ b/tests/time_tests.py @@ -1,7 +1,7 @@ #!/usr/bin/python3 """Tests for the Timestamp class.""" # -# (C) Pywikibot team, 2014-2022 +# (C) Pywikibot team, 2014-2023 # # Distributed under the terms of the MIT license. # @@ -115,13 +115,6 @@ self.assertRaisesRegex(ValueError, regex): Timestamp.set_timestamp(timestr) - def test_clone(self): - """Test cloning a Timestamp instance.""" - t1 = Timestamp.utcnow() - t2 = t1.clone() - self.assertEqual(t1, t2) - self.assertIsInstance(t2, Timestamp) - def test_instantiate_from_instance(self): """Test passing instance to factory methods works.""" t1 = Timestamp.utcnow() -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/871888 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Idbb52a6f9336b8bb194a45c70fc92eb322a552ff Gerrit-Change-Number: 871888 Gerrit-PatchSet: 3 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: RoySmith <roy(a)panix.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year, 4 months

[Gerrit] ...core[master]: [doc] Update LICENSE

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/874029 ) Change subject: [doc] Update LICENSE ...................................................................... [doc] Update LICENSE Change-Id: Ib1a3e3ac02c2816284363913d308232f254d38f7 --- M LICENSE 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/LICENSE b/LICENSE index a489db5..5e7abc3 100644 --- a/LICENSE +++ b/LICENSE @@ -1,4 +1,4 @@ -Copyright (c) Pywikibot team, 2003-2022 +Copyright (c) Pywikibot team, 2003-2023 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/874029 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib1a3e3ac02c2816284363913d308232f254d38f7 Gerrit-Change-Number: 874029 Gerrit-PatchSet: 1 Gerrit-Owner: Zabe <zabe(a)avorwerk.net> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

1 year, 4 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits January 2023