Pywikibot-commits March 2021

pywikibot-commits@lists.wikimedia.org

1 participants
142 discussions

[Gerrit] ...core[master]: [cleanup] Use GeneratorFactory.handle_arg

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/667542 ) Change subject: [cleanup] Use GeneratorFactory.handle_arg ...................................................................... [cleanup] Use GeneratorFactory.handle_arg Bug: T271437 Change-Id: If513c6427b9a2089050a04968b388dc49d0d4b2c --- M tests/pagegenerators_tests.py 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index 93dfdc9..7d84dbe 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -8,6 +8,7 @@ import datetime import logging import sys +import unittest from contextlib import suppress from typing import Optional @@ -28,7 +29,6 @@ from tests import join_data_path, mock from tests.aspects import ( - unittest, TestCase, DeprecationTestCase, WikidataTestCase, @@ -715,7 +715,7 @@ """Test unsupported option.""" gf = pagegenerators.GeneratorFactory(site=self.get_site()) with self.assertRaises(UnknownExtension): - gf.handleArg('-ql:2') + gf.handle_arg('-ql:2') def test_one_excluded_namespaces(self): """Test one excluded namespaces.""" @@ -1039,13 +1039,13 @@ gen = gf.getCombinedGenerator() self.assertIsNotNone(gen) with self.assertRaises(ValueError): - gf.handleArg('-recentchanges:3,2,1') + gf.handle_arg('-recentchanges:3,2,1') with self.assertRaises(ValueError): - gf.handleArg('-recentchanges:12,-12') + gf.handle_arg('-recentchanges:12,-12') with self.assertRaises(ValueError): - gf.handleArg('-recentchanges:visualeditor,3,2,1') + gf.handle_arg('-recentchanges:visualeditor,3,2,1') with self.assertRaises(ValueError): - gf.handleArg('-recentchanges:"mobile edit,-10,20"') + gf.handle_arg('-recentchanges:"mobile edit,-10,20"') def test_recentchanges_rctag(self): """Test recentchanges generator with recent changes tag.""" @@ -1254,7 +1254,7 @@ .format(self.site)) gf = pagegenerators.GeneratorFactory(site=self.site) with self.assertRaises(AssertionError): - gf.handleArg('-linter:dummy') + gf.handle_arg('-linter:dummy') def test_linter_generator_show(self): """Test generator of pages with lint errors.""" @@ -1265,7 +1265,7 @@ self.assertEqual(cm.exception.code, 0) else: with self.assertRaises(UnknownExtension): - gf.handleArg('-linter:show') + gf.handle_arg('-linter:show') def test_querypage_generator_with_valid_page(self): """Test generator of pages with lint errors.""" @@ -1283,7 +1283,7 @@ """Test generator of pages with lint errors.""" gf = pagegenerators.GeneratorFactory(site=self.site) with self.assertRaises(AssertionError): - gf.handleArg('-querypage:dummy') + gf.handle_arg('-querypage:dummy') def test_querypage_generator_with_no_page(self): """Test generator of pages with lint errors.""" @@ -1509,7 +1509,7 @@ self.assertFalse(gf.handle_arg('-log')) self.assertFalse(gf.handle_arg('-log:text_here')) with self.assertRaises(NotImplementedError): - gf.handleArg('-logevents:anyevent') + gf.handle_arg('-logevents:anyevent') # test that old format log option is not handled by any handler method. gf_mock = mock.create_autospec(gf) self.assertFalse(factory.handle_arg(gf_mock, '-anotherlog')) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/667542 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: If513c6427b9a2089050a04968b388dc49d0d4b2c Gerrit-Change-Number: 667542 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 2 months

[Gerrit] ...core[master]: [fix] fix MissingPackageTestCase.test_cosmetic_changes_hook

by jenkins-bot (Code Review)

jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/667539 ) Change subject: [fix] fix MissingPackageTestCase.test_cosmetic_changes_hook ...................................................................... [fix] fix MissingPackageTestCase.test_cosmetic_changes_hook content model of wikidata is 'wikibase-item' Bug: T276034 Change-Id: I7488868dac4046d8664f60461518fe122b14f564 --- M tests/i18n_tests.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/i18n_tests.py b/tests/i18n_tests.py index 8b6b99a..9a4875a 100644 --- a/tests/i18n_tests.py +++ b/tests/i18n_tests.py @@ -547,11 +547,14 @@ # check cc settings config.cosmetic_changes_mylang_only = False self.assertFalse(page.isTalkPage()) - self.assertEqual(page.content_model, 'wikitext') self.assertNotIn(pywikibot.calledModuleName(), config.cosmetic_changes_deny_script) self.assertFalse(config.cosmetic_changes_mylang_only) + if page.content_model != 'wikitext': + self.skipTest('Wrong content model {!r} for cosmetic_changes' + .format(page.content_model)) + summary = 'Working on Test page at site {}'.format(self.site) msg = page._cosmetic_changes_hook(summary) self.assertEqual(msg, summary + '; cosmetic changes') -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/667539 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I7488868dac4046d8664f60461518fe122b14f564 Gerrit-Change-Number: 667539 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged

3 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits March 2021