jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/338102 )
Change subject: Remove fixme note
......................................................................
Remove fixme note
Per T74941#794299, MediaWiki does it since 1.11 while Pywikibot now
supports 1.14 or higher.
Change-Id: I1e941d6b760a32919465c4d01bbd3e0f3143629c
---
M pywikibot/cosmetic_changes.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/cosmetic_changes.py b/pywikibot/cosmetic_changes.py
index 2684d81..f1923a8 100755
--- a/pywikibot/cosmetic_changes.py
+++ b/pywikibot/cosmetic_changes.py
@@ -619,8 +619,6 @@
Newer MediaWiki versions automatically place a non-breaking space in
front of a percent sign, so it is no longer required to place it
manually.
-
- FIXME: which version should this be run on?
"""
text = textlib.replaceExcept(text, r'(\d) %', r'\1 %',
['timeline'])
--
To view, visit https://gerrit.wikimedia.org/r/338102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e941d6b760a32919465c4d01bbd3e0f3143629c
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337861 )
Change subject: Use imported InvalidTitle
......................................................................
Use imported InvalidTitle
InvalidTitle is imported and should be used instead of the
intrinsic pywikibot.InvalidTitle
Change-Id: I7647df56085431dd2e25417b4ca79b638c066b74
---
M pywikibot/textlib.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py
index c8e2926..03d8da4 100644
--- a/pywikibot/textlib.py
+++ b/pywikibot/textlib.py
@@ -868,7 +868,7 @@
if previous_key_count == len(result):
pywikibot.warning('[getLanguageLinks] 2 or more interwiki '
'links point to site %s.' % site)
- except pywikibot.InvalidTitle:
+ except InvalidTitle:
pywikibot.output(u'[getLanguageLinks] Text contains invalid '
u'interwiki link [[%s:%s]].'
% (lang, pagetitle))
--
To view, visit https://gerrit.wikimedia.org/r/337861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7647df56085431dd2e25417b4ca79b638c066b74
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>
Build Update for wikimedia/pywikibot-core
-------------------------------------
Build: #3853
Status: Errored
Duration: 28 minutes and 6 seconds
Commit: c3e9145 (master)
Author: dalba
Message: test_cleanUpLinks_pipes: Expect uppercase first letter
The first letter of link targets is capitalized when appropriate for
de:wikipedia.[1] TestCosmeticChanges is perfomed on de:wikipedia.[2]
Therefore it should be expected to have an uppercase letter in this
case which is a method of a sub-class of TestCosmeticChanges.
[1]: https://goo.gl/QdULBb
[2]: https://goo.gl/YAfB6y
Bug: T158050
Change-Id: I92159e61156a06ca9b7ad82fecd1df3572ef4b06
View the changeset: https://github.com/wikimedia/pywikibot-core/compare/85da7335690d...c3e91457…
View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/201825802
--
You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/337768 )
Change subject: test_cleanUpLinks_pipes: Expect uppercase first letter
......................................................................
test_cleanUpLinks_pipes: Expect uppercase first letter
The first letter of link targets is capitalized when appropriate for
de:wikipedia.[1] TestCosmeticChanges is perfomed on de:wikipedia.[2]
Therefore it should be expected to have an uppercase letter in this
case which is a method of a sub-class of TestCosmeticChanges.
[1]: https://goo.gl/QdULBb
[2]: https://goo.gl/YAfB6y
Bug: T158050
Change-Id: I92159e61156a06ca9b7ad82fecd1df3572ef4b06
---
M tests/cosmetic_changes_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/cosmetic_changes_tests.py b/tests/cosmetic_changes_tests.py
index 6a7112d..cc3947c 100644
--- a/tests/cosmetic_changes_tests.py
+++ b/tests/cosmetic_changes_tests.py
@@ -247,7 +247,7 @@
def test_cleanUpLinks_pipes(self):
"""Test cleanUpLinks method."""
- self.assertEqual('[[no|no change]]',
+ self.assertEqual('[[No|no change]]',
self.cct.cleanUpLinks('[[no|no change]]'))
self.assertEqual('[[title]]',
self.cct.cleanUpLinks('[[title|title]]'))
--
To view, visit https://gerrit.wikimedia.org/r/337768
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92159e61156a06ca9b7ad82fecd1df3572ef4b06
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>