Pywikibot-commits July 2016

pywikibot-commits@lists.wikimedia.org

2 participants
53 discussions

[Gerrit] Rename TestContainer to Container - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Rename TestContainer to Container ...................................................................... Rename TestContainer to Container The automatic test discovery will try to run the tests in any class that starts with test. The TestContainer class does not contain any tests and should therefore be just called Container to increase the compatibility with pytest. Change-Id: Ia76cbdeb4591e6f8b65e03e0928ab793e7b6e2fb --- M tests/sparql_tests.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/sparql_tests.py b/tests/sparql_tests.py index f7c2f5c..d86368e 100644 --- a/tests/sparql_tests.py +++ b/tests/sparql_tests.py @@ -74,7 +74,7 @@ """ -class TestContainer(object): +class Container(object): """Simple test container for return values.""" def __init__(self, value): @@ -90,7 +90,7 @@ @patch.object(sparql.http, 'fetch') def testQuerySelect(self, mock_method): """Test SELECT query.""" - mock_method.return_value = TestContainer(SQL_RESPONSE) + mock_method.return_value = Container(SQL_RESPONSE) q = sparql.SparqlQuery() res = q.select('SELECT * WHERE { ?x ?y ?z }') self.assertIsInstance(res, list, 'Result is not a list') @@ -108,7 +108,7 @@ @patch.object(sparql.http, 'fetch') def testQuerySelectFull(self, mock_method): """Test SELECT query with full data.""" - mock_method.return_value = TestContainer(SQL_RESPONSE) + mock_method.return_value = Container(SQL_RESPONSE) q = sparql.SparqlQuery() res = q.select('SELECT * WHERE { ?x ?y ?z }', full_data=True) self.assertIsInstance(res, list, 'Result is not a list') @@ -130,7 +130,7 @@ @patch.object(sparql.http, 'fetch') def testGetItems(self, mock_method): """Test item list retrieval via SPARQL.""" - mock_method.return_value = TestContainer(SQL_RESPONSE) + mock_method.return_value = Container(SQL_RESPONSE) q = sparql.SparqlQuery() res = q.get_items('SELECT * WHERE { ?x ?y ?z }', 'cat') self.assertSetEqual(res, set(['Q498787', 'Q677525'])) @@ -138,13 +138,13 @@ @patch.object(sparql.http, 'fetch') def testQueryAsk(self, mock_method): """Test ASK query.""" - mock_method.return_value = TestContainer(RESPONSE_TRUE) + mock_method.return_value = Container(RESPONSE_TRUE) q = sparql.SparqlQuery() res = q.ask('ASK { ?x ?y ?z }') self.assertTrue(res) - mock_method.return_value = TestContainer(RESPONSE_FALSE) + mock_method.return_value = Container(RESPONSE_FALSE) res = q.ask('ASK { ?x ?y ?z }') self.assertFalse(res) -- To view, visit https://gerrit.wikimedia.org/r/296818 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia76cbdeb4591e6f8b65e03e0928ab793e7b6e2fb Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Tobias47n9e <tobias47n9e(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

7 years, 10 months

[Gerrit] Add revid to Notification object - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Add revid to Notification object ...................................................................... Add revid to Notification object Since most edit-related notifications include revid attributes, we should include the revids in the Notification objects as we're building them (if they exist). Change-Id: Ifdb98e7c79729a1c2f7a5c4c4366e28071a48239 --- M pywikibot/echo.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/echo.py b/pywikibot/echo.py index f9fa001..6d6587b 100644 --- a/pywikibot/echo.py +++ b/pywikibot/echo.py @@ -43,6 +43,7 @@ notif.read = False notif.content = data.get('*', None) + notif.revid = data.get('revid', None) return notif -- To view, visit https://gerrit.wikimedia.org/r/297118 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdb98e7c79729a1c2f7a5c4c4366e28071a48239 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: APerson <danielhglus(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

7 years, 10 months

[Gerrit] Fix notifications building from JSON - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Fix notifications building from JSON ...................................................................... Fix notifications building from JSON Sometimes (like in welcome messages), notifications don't have a 'title' property, so we shouldn't assume there is one. Bug: T139015 Change-Id: I83e480d04e8e09aa9bcb5edef4f56b47d150e199 --- M pywikibot/echo.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/echo.py b/pywikibot/echo.py index 8c9584a..f9fa001 100644 --- a/pywikibot/echo.py +++ b/pywikibot/echo.py @@ -27,8 +27,10 @@ notif.category = data['category'] notif.timestamp = pywikibot.Timestamp.fromtimestampformat(data['timestamp']['mw']) - # TODO: use 'namespace-key' + 'text' ? - notif.page = pywikibot.Page(site, data['title']['full']) + if 'title' in data and 'full' in data['title']: + notif.page = pywikibot.Page(site, data['title']['full']) + else: + notif.page = None if 'agent' in data and 'name' in data['agent']: notif.agent = pywikibot.User(site, data['agent']['name']) -- To view, visit https://gerrit.wikimedia.org/r/296688 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83e480d04e8e09aa9bcb5edef4f56b47d150e199 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: APerson <danielhglus(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot <>

7 years, 10 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits July 2016