jenkins-bot has submitted this change and it was merged.
Change subject: Allow non-urlencoded permalink
......................................................................
Allow non-urlencoded permalink
With browsers increasing their support for non-ascii urls the need
for the urlencode of the title is not always guaranteed. Adding an
optional parameter to permalink ensures this option becomes
available.
Change-Id: Ia7a5edd89347c6d1462fb220fd514469ac14dd83
---
M pywikibot/page.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index faf693b..a9c4e7a 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -460,16 +460,20 @@
# TODO: what about redirects, errors?
return self._revisions[oldid].text
- def permalink(self, oldid=None):
+ def permalink(self, oldid=None, percent_encoded=True):
"""Return the permalink URL of an old revision of this page.
@param oldid: The revid of the revision desired.
@rtype: unicode
"""
+ if percent_encoded:
+ title = self.title(asUrl=True)
+ else:
+ title = self.title(asUrl=False).replace(' ', '_')
return "//%s%s/index.php?title=%s&oldid=%s" \
% (self.site.hostname(),
self.site.scriptpath(),
- self.title(asUrl=True),
+ title,
(oldid if oldid is not None else self.latest_revision_id))
@property
--
To view, visit https://gerrit.wikimedia.org/r/290215
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7a5edd89347c6d1462fb220fd514469ac14dd83
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Lokal Profil <lokal.profil(a)gmail.com>
Gerrit-Reviewer: Jean-Frédéric <jeanfrederic.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Lokal Profil <lokal.profil(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: [bugfix] pass User page object to NotEmailableError
......................................................................
[bugfix] pass User page object to NotEmailableError
NotEmailableError is derived from PageRelatedError and
expect a page object as first parameter but got a string.
Bug: T135364
Change-Id: I5aad3aaa76802884b744f89a633d716e1aab5286
---
M pywikibot/page.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index d9d0f3f..0ef0e82 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -3049,7 +3049,7 @@
@rtype: bool
"""
if not self.isEmailable():
- raise NotEmailableError('%s is not mailable' % self.username)
+ raise NotEmailableError(self)
if not self.site.has_right('sendemail'):
raise UserRightsError('You don\'t have permission to send mail')
--
To view, visit https://gerrit.wikimedia.org/r/288901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5aad3aaa76802884b744f89a633d716e1aab5286
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Run codecov on CI job failure
......................................................................
Run codecov on CI job failure
Bug: T74863
Change-Id: Ic18750859336034c77d5e8757f6bd9cb7b74bd3a
---
M .appveyor.yml
M .travis.yml
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
AbdealiJK: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.appveyor.yml b/.appveyor.yml
index 6e24d79..c7eff52 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -97,7 +97,10 @@
- set PYSETUP_TEST_NO_UI=1
- "%CMD_IN_ENV% coverage run setup.py test"
-after_test:
+on_failure:
+ - codecov
+
+on_success:
- codecov
artifacts:
diff --git a/.travis.yml b/.travis.yml
index fa8fef8..87954ee 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -115,6 +115,9 @@
after_success:
codecov
+after_failure:
+ codecov
+
env:
global:
# This is the encrypted password for Wikimedia SUL user 'Pywikibot-test',
--
To view, visit https://gerrit.wikimedia.org/r/290147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic18750859336034c77d5e8757f6bd9cb7b74bd3a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: AbdealiJK <abdealikothari(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: [bugfix] isRegistered() must respect an unknown registration time
......................................................................
[bugfix] isRegistered() must respect an unknown registration time
- Return True for User.isRegistered() even when the registration time
is unknown. The registration time may be None when the user was registered
more than 10 years ago.
- Add tests for this case.
Bug: T135828
Change-Id: Ia98ae100cf52f7da15eb184b20dbe2669567ad69
---
M pywikibot/page.py
M tests/user_tests.py
2 files changed, 12 insertions(+), 1 deletion(-)
Approvals:
Mpaa: Looks good to me, approved
Xqt: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index faf693b..8769b17 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -2885,7 +2885,8 @@
@rtype: bool
"""
- return self.registration(force) is not None
+ # T135828: the registration timestamp may be None but the key exists
+ return 'registration' in self.getprops(force)
def isAnonymous(self):
"""
diff --git a/tests/user_tests.py b/tests/user_tests.py
index 3dc2e15..353188a 100644
--- a/tests/user_tests.py
+++ b/tests/user_tests.py
@@ -36,6 +36,16 @@
self.assertTrue(user.isEmailable())
self.assertIn('userid', user.getprops())
+ def test_registered_user_without_timestamp(self):
+ """Test registered user when registration timestamp is None."""
+ user = User(self.site, 'Ulfb')
+ self.assertTrue(user.isRegistered())
+ self.assertFalse(user.isAnonymous())
+ self.assertIsNone(user.registration())
+ self.assertIsNone(user.getprops()['registration'])
+ self.assertGreater(user.editCount(), 0)
+ self.assertIn('userid', user.getprops())
+
def test_anonymous_user(self):
"""Test registered user."""
user = User(self.site, '123.45.67.89')
--
To view, visit https://gerrit.wikimedia.org/r/289847
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia98ae100cf52f7da15eb184b20dbe2669567ad69
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Add '-page' parameter to cfd.py to specify CFD working page
......................................................................
Add '-page' parameter to cfd.py to specify CFD working page
This is a forward port of a change from pywikibot-compat that I wrote
a few years back.
Bug: T135354
Change-Id: I632f70b7ccab2f9d0159bcab2ef3f519fa7a85df
---
M scripts/cfd.py
1 file changed, 18 insertions(+), 9 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/cfd.py b/scripts/cfd.py
index b301919..96fa0a3 100755
--- a/scripts/cfd.py
+++ b/scripts/cfd.py
@@ -23,15 +23,14 @@
#
import re
+import sys
import pywikibot
-from pywikibot import config2 as config
-
from scripts.category import CategoryMoveRobot as CategoryMoveBot
-# The location of the CFD working page.
-cfdPage = u'Wikipedia:Categories for discussion/Working'
+
+DEFAULT_CFD_PAGE = 'Wikipedia:Categories for discussion/Working'
# A list of templates that are used on category pages as part of the CFD
# process that contain information such as the link to the per-day discussion page.
@@ -81,13 +80,23 @@
@param args: command line arguments
@type args: list of unicode
"""
- pywikibot.handle_args(args)
+ cfd_page = DEFAULT_CFD_PAGE
+ local_args = pywikibot.handle_args(args)
- if config.family != 'wikipedia' or config.mylang != 'en':
- pywikibot.warning('CFD does work only on the English Wikipedia.')
- return
+ for arg in local_args:
+ if arg.startswith('-page'):
+ if len(arg) == len('-page'):
+ cfd_page = pywikibot.input('Enter the CFD working page to use:')
+ else:
+ cfd_page = arg[len('-page:'):]
- page = pywikibot.Page(pywikibot.Site(), cfdPage)
+ page = pywikibot.Page(pywikibot.Site(), cfd_page)
+ try:
+ page.get()
+ except pywikibot.NoPage:
+ pywikibot.error(
+ 'CFD working page "{0}" does not exist!'.format(cfd_page))
+ sys.exit(1)
# Variable declarations
day = 'None'
--
To view, visit https://gerrit.wikimedia.org/r/290004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I632f70b7ccab2f9d0159bcab2ef3f519fa7a85df
Gerrit-PatchSet: 6
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Cyde <cydeweys(a)gmail.com>
Gerrit-Reviewer: Cyde <cydeweys(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Add a trusty build
......................................................................
Add a trusty build
Use nb.wikipedia as it is an alias for no.wikipedia,
and there isnt a full test run of an alias.
Change-Id: Ic248ecb7fa28a0168bf5c90750cc107924ab8c75
---
M .travis.yml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.travis.yml b/.travis.yml
index 5db2095..fa8fef8 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -133,6 +133,10 @@
- python: '2.7_with_system_site_packages' # equivalent to virtualenv: system_site_packages: true
env: LANGUAGE=he FAMILY=wikivoyage SITE_ONLY=1
- python: '2.7'
+ env: LANGUAGE=nb FAMILY=wikipedia DIST=trusty
+ dist: trusty
+ sudo: required
+ - python: '2.7'
env: LANGUAGE=en FAMILY=wpbeta SITE_ONLY=1 OAUTH_DOMAIN="en.wikipedia.beta.wmflabs.org"
- python: '3.3'
env: LANGUAGE=zh FAMILY=wpbeta SITE_ONLY=1 OAUTH_DOMAIN="zh.wikipedia.beta.wmflabs.org"
--
To view, visit https://gerrit.wikimedia.org/r/289818
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic248ecb7fa28a0168bf5c90750cc107924ab8c75
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Use flake8-mock and fix mock.assert_called_once
......................................................................
Use flake8-mock and fix mock.assert_called_once
diff_tests was created using mock in 3c8c5eae, with
a call to assert_called_once, which doesnt do anything.
assert_called_once_with is the correct function name,
but it is best avoided by using call_count.
Also enable flake8-mock, which flags this as M001.
Bug: T134341
Change-Id: I9f6e0c5c2b0f41b5b6d4cef33dcc3829b8dc1e05
---
M dev-requirements.txt
M tests/diff_tests.py
M tox.ini
3 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/dev-requirements.txt b/dev-requirements.txt
index baed441..44499a0 100644
--- a/dev-requirements.txt
+++ b/dev-requirements.txt
@@ -17,6 +17,7 @@
pyflakes>=0.9
flake8
flake8-docstrings>=0.2.6
+flake8-mock
codecov
coverage
mock ; python_version < '3'
diff --git a/tests/diff_tests.py b/tests/diff_tests.py
index 402ad74..b94911f 100644
--- a/tests/diff_tests.py
+++ b/tests/diff_tests.py
@@ -94,7 +94,7 @@
@patch('{0}.__import__'.format('__builtin__' if PY2 else 'builtins'),
- side_effect=ImportError)
+ side_effect=ImportError, autospec=True)
class TestNoBeautifulSoup(TestCase):
"""Test functions when BeautifulSoup is not installes."""
@@ -104,7 +104,7 @@
def test_html_comparator(self, mocked_import):
"""Test html_comparator when bs4 not installed."""
self.assertRaises(ImportError, html_comparator, '')
- mocked_import.assert_called_once()
+ self.assertEqual(mocked_import.call_count, 1)
self.assertIn('bs4', mocked_import.call_args[0])
diff --git a/tox.ini b/tox.ini
index 040e501..ea79390 100644
--- a/tox.ini
+++ b/tox.ini
@@ -38,6 +38,7 @@
flake8-import-order
flake8-tuple>=0.2.8
flake8-print>=2.0.1
+ flake8-mock
[testenv:flake8-py3]
commands =
--
To view, visit https://gerrit.wikimedia.org/r/289894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f6e0c5c2b0f41b5b6d4cef33dcc3829b8dc1e05
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Separate testNonAlphabeticalCharactersInSection test
......................................................................
Separate testNonAlphabeticalCharactersInSection test
- The first test fails due to T133276 but the second works well but is
never reached. Splitting this test ensures the second test to be executed.
- Follow naming convention.
Change-Id: Ib33786dc61d286db53c9d2cdf2882beb55fadaeb
---
M tests/textlib_tests.py
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py
index a9be159..151b194 100644
--- a/tests/textlib_tests.py
+++ b/tests/textlib_tests.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
"""Test textlib module."""
#
-# (C) Pywikibot team, 2011-2015
+# (C) Pywikibot team, 2011-2016
#
# Distributed under the terms of the MIT license.
#
@@ -74,11 +74,14 @@
self.assertNotContains('enwiki_help_editing', 'Minor_Edits',
'section hashes are case-sensitive')
- @unittest.expectedFailure
- def testNonAlphabeticalCharactersInSection(self):
- """Test with non-alphabetical chars in section."""
+ @unittest.expectedFailure # TODO: T133276
+ def test_encoded_chars_in_section(self):
+ """Test encoded chars in section."""
self.assertContains('enwiki_help_editing', 'Talk_.28discussion.29_pages',
'As used in the TOC')
+
+ def test_underline_characters_in_section(self):
+ """Test with underline chars in section."""
self.assertContains('enwiki_help_editing', 'Talk_(discussion)_pages',
'Understood by mediawiki')
--
To view, visit https://gerrit.wikimedia.org/r/284684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib33786dc61d286db53c9d2cdf2882beb55fadaeb
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: Re-enable APT addon for jobs in matrix include
......................................................................
Re-enable APT addon for jobs in matrix include
The installation of apt packages was inadvertantly disabled in August 2015
with 8004cdfe29 due to https://github.com/travis-ci/travis-ci/issues/5405 .
Bug: T135701
Change-Id: Iaaa562a145b3aca8737af4ac3fc2418496d2747a
---
M .travis.yml
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.travis.yml b/.travis.yml
index 400862f..efd9c68 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -12,8 +12,7 @@
- '2.6'
# OSX builds do not yet support Python
-os:
- - linux
+os: linux
addons:
apt:
--
To view, visit https://gerrit.wikimedia.org/r/289659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaa562a145b3aca8737af4ac3fc2418496d2747a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>
jenkins-bot has submitted this change and it was merged.
Change subject: travis: Use pytest-attrib for SITE_ONLY=1 jobs
......................................................................
travis: Use pytest-attrib for SITE_ONLY=1 jobs
Earlier, some travis builds used nose because there was no equivalent
of nose-attrib. Now, the plugin pytest-attrib has been created, so
we use this instead.
Now all our travis builds can use pytest instead of nose.
Bug: T135659
Change-Id: I81a9823e803bbf237f4aa65e9c1ba6ae812514ef
---
M .travis.yml
M dev-requirements.txt
2 files changed, 18 insertions(+), 13 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.travis.yml b/.travis.yml
index 400862f..2a57533 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -30,10 +30,14 @@
# Instead install requests in the before_script step below.
- if [[ "$PYSETUP_TEST_EXTRAS" != '1' ]]; then rm requirements.txt ; fi
- - if [[ "$SITE_ONLY" == '1' ]]; then
- export USE_NOSE=1 ;
- elif [[ "$PYSETUP_TEST_EXTRAS" != '1' ]]; then
+ # When the env variable USE_NOSE or USE_PYTEST is set, the appropriate
+ # tool is used, else PYTEST is taken as the default
+ - if [[ "$PYSETUP_TEST_EXTRAS" != '1' && "$USE_NOSE" != '1' && "$USE_PYTEST" != '1' ]]; then
export USE_PYTEST=1 ;
+ fi
+
+ - if [[ "$SITE_ONLY" == '1' ]]; then
+ echo "Running site tests only code ${LANGUAGE} on family ${FAMILY}" ;
fi
- export GITHUB_USER=`echo $TRAVIS_REPO_SLUG | cut -d '/' -f 1`
@@ -95,14 +99,16 @@
- if [[ "$USE_NOSE" == "1" ]]; then
nosetests --version ;
if [[ "$SITE_ONLY" == "1" ]]; then
- echo "Running site tests only code ${LANGUAGE} on family ${FAMILY}" ;
python setup.py nosetests --tests tests --verbosity=2 -a "family=$FAMILY,code=$LANGUAGE" --with-trim --with-coverage --cover-package=. ;
else
python setup.py nosetests --tests tests --verbosity=2 --with-trim --with-coverage --cover-package=. ;
fi ;
elif [[ "$USE_PYTEST" == "1" ]]; then
- pip install --upgrade pytest-runner pytest-cov pytest-timeout "pytest>=2.8.0" ;
- python setup.py pytest --addopts="-vvv -s --timeout=300 --cov=." ;
+ if [[ "$SITE_ONLY" == "1" ]]; then
+ python setup.py pytest --addopts="-vvv -s --timeout=$TEST_TIMEOUT --cov=. -a \"family=='$FAMILY' and code=='$LANGUAGE'\"" ;
+ else
+ python setup.py pytest --addopts="-vvv -s --timeout=$TEST_TIMEOUT --cov=." ;
+ fi
else
coverage run setup.py test ;
fi
@@ -117,6 +123,7 @@
# the github repository 'wikimedia/pywikibot-core'.
# See http://docs.travis-ci.com/user/encryption-keys/ for more information.
- secure: kofInMlisiTBt9o/Ustc/vySlkKfxGzGCX2LwA1D2waym8sDTS0o5gMJ5LsrT/BUKwZbe1vLozPHqZrrkQvsdTml+DpZuotzdILs0m0f3BUoexEC6OON5IDljuxFyETrD1Ug44ih5Mc4lVFOdTcBzg501ZmswGwQrBvg/OyEFfE=
+ - TEST_TIMEOUT: 300
matrix:
- LANGUAGE=en FAMILY=wikipedia PYWIKIBOT2_TEST_PROD_ONLY=1
diff --git a/dev-requirements.txt b/dev-requirements.txt
index 7bbac29..baed441 100644
--- a/dev-requirements.txt
+++ b/dev-requirements.txt
@@ -2,13 +2,11 @@
#
unittest2==0.8.0 ; python_full_version < '2.7.3'
-pytest
-# These are used by only some Travis builds
-# pytest-timeout needs >=2.8.0
-# pytest>=2.8.0
-# pytest-timeout
-# pytest-runner
-# pytest-cov
+pytest>=2.8.0
+pytest-timeout
+pytest-runner
+pytest-cov
+pytest-attrib
six
--
To view, visit https://gerrit.wikimedia.org/r/289605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a9823e803bbf237f4aa65e9c1ba6ae812514ef
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: AbdealiJK <abdealikothari(a)gmail.com>
Gerrit-Reviewer: AbdealiJK <abdealikothari(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>