Pywikibot-commits December 2014

pywikibot-commits@lists.wikimedia.org

2 participants
317 discussions

Passed: wikimedia/pywikibot-core#1845 (master - bb85012)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #1845 Status: Passed Duration: 41 minutes and 33 seconds Commit: bb85012 (master) Author: John Vandenberg Message: Add tests for XML export v0.10 The XML unit tests use XML data files using export v0.3. MediaWiki export format is currently version v0.10. Moved XML export v0.3 data files into tests/data/xml subdirectory. Add allowed_failure test for edit summary not being decoded. Bug: T85334 Change-Id: I82fccdafcf302d77dd3c6c5ce7713e72a4412e5c View the changeset: https://github.com/wikimedia/pywikibot-core/compare/95230efd39b8...bb850121… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/45137921 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

9 years, 4 months

[Gerrit] Add tests for XML export v0.10 - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Add tests for XML export v0.10 ...................................................................... Add tests for XML export v0.10 The XML unit tests use XML data files using export v0.3. MediaWiki export format is currently version v0.10. Moved XML export v0.3 data files into tests/data/xml subdirectory. Add allowed_failure test for edit summary not being decoded. Bug: T85334 Change-Id: I82fccdafcf302d77dd3c6c5ce7713e72a4412e5c --- R tests/data/xml/article-pear.xml R tests/data/xml/article-pyrus-utf16.xml R tests/data/xml/article-pyrus-utf16.xml.bz2 R tests/data/xml/article-pyrus.xml R tests/data/xml/article-pyrus.xml.bz2 A tests/data/xml/pair-0.10.xml M tests/xmlreader_tests.py 7 files changed, 172 insertions(+), 12 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/data/article-pear.xml b/tests/data/xml/article-pear.xml similarity index 100% rename from tests/data/article-pear.xml rename to tests/data/xml/article-pear.xml diff --git a/tests/data/article-pyrus-utf16.xml b/tests/data/xml/article-pyrus-utf16.xml similarity index 100% rename from tests/data/article-pyrus-utf16.xml rename to tests/data/xml/article-pyrus-utf16.xml Binary files differ diff --git a/tests/data/article-pyrus-utf16.xml.bz2 b/tests/data/xml/article-pyrus-utf16.xml.bz2 similarity index 100% rename from tests/data/article-pyrus-utf16.xml.bz2 rename to tests/data/xml/article-pyrus-utf16.xml.bz2 Binary files differ diff --git a/tests/data/article-pyrus.xml b/tests/data/xml/article-pyrus.xml similarity index 100% rename from tests/data/article-pyrus.xml rename to tests/data/xml/article-pyrus.xml diff --git a/tests/data/article-pyrus.xml.bz2 b/tests/data/xml/article-pyrus.xml.bz2 similarity index 100% rename from tests/data/article-pyrus.xml.bz2 rename to tests/data/xml/article-pyrus.xml.bz2 Binary files differ diff --git a/tests/data/xml/pair-0.10.xml b/tests/data/xml/pair-0.10.xml new file mode 100644 index 0000000..500f4dd --- /dev/null +++ b/tests/data/xml/pair-0.10.xml @@ -0,0 +1,112 @@ +<mediawiki xmlns="http://www.mediawiki.org/xml/export-0.10/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.mediawiki.org/xml/export-0.10/ http://www.mediawiki.org/xml/export-0.10.xsd" version="0.10" xml:lang="en"> + <siteinfo> + <sitename>Wikipedia</sitename> + <dbname>enwiki</dbname> + <base>http://en.wikipedia.org/wiki/Main_Page</base> + <generator>MediaWiki 1.25wmf12</generator> + <case>first-letter</case> + <namespaces> + <namespace key="-2" case="first-letter">Media</namespace> + <namespace key="-1" case="first-letter">Special</namespace> + <namespace key="0" case="first-letter" /> + <namespace key="1" case="first-letter">Talk</namespace> + <namespace key="2" case="first-letter">User</namespace> + <namespace key="3" case="first-letter">User talk</namespace> + <namespace key="4" case="first-letter">Wikipedia</namespace> + <namespace key="5" case="first-letter">Wikipedia talk</namespace> + <namespace key="6" case="first-letter">File</namespace> + <namespace key="7" case="first-letter">File talk</namespace> + <namespace key="8" case="first-letter">MediaWiki</namespace> + <namespace key="9" case="first-letter">MediaWiki talk</namespace> + <namespace key="10" case="first-letter">Template</namespace> + <namespace key="11" case="first-letter">Template talk</namespace> + <namespace key="12" case="first-letter">Help</namespace> + <namespace key="13" case="first-letter">Help talk</namespace> + <namespace key="14" case="first-letter">Category</namespace> + <namespace key="15" case="first-letter">Category talk</namespace> + <namespace key="100" case="first-letter">Portal</namespace> + <namespace key="101" case="first-letter">Portal talk</namespace> + <namespace key="108" case="first-letter">Book</namespace> + <namespace key="109" case="first-letter">Book talk</namespace> + <namespace key="118" case="first-letter">Draft</namespace> + <namespace key="119" case="first-letter">Draft talk</namespace> + <namespace key="446" case="first-letter">Education Program</namespace> + <namespace key="447" case="first-letter">Education Program talk</namespace> + <namespace key="710" case="first-letter">TimedText</namespace> + <namespace key="711" case="first-letter">TimedText talk</namespace> + <namespace key="828" case="first-letter">Module</namespace> + <namespace key="829" case="first-letter">Module talk</namespace> + <namespace key="2600" case="first-letter">Topic</namespace> + </namespaces> + </siteinfo> + <page> + <title>Çullu, Agdam</title> + <ns>0</ns> + <id>19252820</id> + <revision> + <id>237382899</id> + <timestamp>2008-09-09T22:40:15Z</timestamp> + <contributor> + <username>Carlossuarez46</username> + <id>23407</id> + </contributor> + <comment>moved [[Çullu, Agdam]] to [[Çullu, Quzanlı]]:&#32;dab</comment> + <model>wikitext</model> + <format>text/x-wiki</format> + <text xml:space="preserve" bytes="30">#REDIRECT [[Çullu, Quzanlı]]</text> + <sha1>9onarlg8ywgp11wnrddqebdry0jyz56</sha1> + </revision> + <revision> + <id>237383099</id> + <parentid>237382899</parentid> + <timestamp>2008-09-09T22:41:28Z</timestamp> + <contributor> + <username>Carlossuarez46</username> + <id>23407</id> + </contributor> + <comment>create dab</comment> + <model>wikitext</model> + <format>text/x-wiki</format> + <text xml:space="preserve" bytes="305">'''Çullu, Agdam''' may refer to: +*[[Çullu, Quzanlı]] +*[[Çullu (Chullu Vtoroye), Agdam]] + +{{geodis}} + +</text> + <sha1>senkho7ycefskq5d8mllalt33oxiy7v</sha1> + </revision> + </page> + <page> + <title>Talk:Çullu, Agdam</title> + <ns>1</ns> + <id>19252824</id> + <revision> + <id>237382916</id> + <timestamp>2008-09-09T22:40:18Z</timestamp> + <contributor> + <username>Carlossuarez46</username> + <id>23407</id> + </contributor> + <comment>moved [[Talk:Çullu, Agdam]] to [[Talk:Çullu, Quzanlı]]:&#32;dab</comment> + <model>wikitext</model> + <format>text/x-wiki</format> + <text xml:space="preserve" bytes="35">#REDIRECT [[Talk:Çullu, Quzanlı]]</text> + <sha1>co53382onr803k6tzfhpi5g83b2egxf</sha1> + </revision> + <revision> + <id>237383127</id> + <parentid>237382916</parentid> + <timestamp>2008-09-09T22:41:38Z</timestamp> + <contributor> + <username>Carlossuarez46</username> + <id>23407</id> + </contributor> + <comment>proj</comment> + <model>wikitext</model> + <format>text/x-wiki</format> + <text xml:space="preserve" bytes="19">{{DisambigProject}}</text> + <sha1>efe5s8flu02zejuj539rfokh6bcwya6</sha1> + </revision> + </page> +</mediawiki> diff --git a/tests/xmlreader_tests.py b/tests/xmlreader_tests.py index 8399d0a..3681e19 100644 --- a/tests/xmlreader_tests.py +++ b/tests/xmlreader_tests.py @@ -7,11 +7,15 @@ # __version__ = '$Id$' - import os.path + from pywikibot import xmlreader + from tests import _data_dir from tests.aspects import unittest, TestCase +from tests.utils import allowed_failure + +_xml_data_dir = os.path.join(_data_dir, 'xml') class XmlReaderTestCase(TestCase): @@ -20,11 +24,19 @@ net = False + def _get_entries(self, filename, **kwargs): + entries = [r for r in + xmlreader.XmlDump(os.path.join(_xml_data_dir, filename), + **kwargs).parse()] + return entries + + +class ExportDotThreeTestCase(XmlReaderTestCase): + + """XML export version 0.3 tests.""" + def test_XmlDumpAllRevs(self): - pages = [r for r in - xmlreader.XmlDump(os.path.join(_data_dir, - "article-pear.xml"), - allrevisions=True).parse()] + pages = self._get_entries('article-pear.xml', allrevisions=True) self.assertEqual(4, len(pages)) self.assertEqual(u"Automated conversion", pages[0].comment) self.assertEqual(u"Pear", pages[0].title) @@ -34,9 +46,7 @@ self.assertEqual(u"Pear", pages[0].title) def test_XmlDumpFirstRev(self): - pages = [r for r in - xmlreader.XmlDump(os.path.join(_data_dir, - "article-pear.xml")).parse()] + pages = self._get_entries("article-pear.xml", allrevisions=False) self.assertEqual(1, len(pages)) self.assertEqual(u"Automated conversion", pages[0].comment) self.assertEqual(u"Pear", pages[0].title) @@ -45,15 +55,16 @@ self.assertTrue(not pages[0].isredirect) def test_XmlDumpRedirect(self): + pages = self._get_entries('article-pyrus.xml', allrevisions=True) pages = [r for r in - xmlreader.XmlDump(os.path.join(_data_dir, + xmlreader.XmlDump(os.path.join(_xml_data_dir, "article-pyrus.xml")).parse()] self.assertTrue(pages[0].isredirect) def _compare(self, previous, variant, all_revisions): - result = [entry.__dict__ for entry in xmlreader.XmlDump( - os.path.join(_data_dir, 'article-pyrus' + variant), - all_revisions).parse()] + entries = self._get_entries('article-pyrus' + variant, + allrevisions=all_revisions) + result = [entry.__dict__ for entry in entries] if previous: self.assertEqual(previous, result) return result @@ -72,6 +83,43 @@ self._compare_variants(False) +class ExportDotTenTestCase(XmlReaderTestCase): + + """XML export version 0.10 tests.""" + + def test_pair(self): + entries = self._get_entries('pair-0.10.xml', allrevisions=True) + self.assertEqual(4, len(entries)) + self.assertTrue(all(entry.title.endswith(u"Çullu, Agdam") + for entry in entries)) + self.assertTrue(all(entry.username == 'Carlossuarez46' + for entry in entries)) + self.assertTrue(all(entry.isredirect is False for entry in entries)) + + articles = [entry for entry in entries if entry.ns == "0"] + talks = [entry for entry in entries if entry.ns == "1"] + + self.assertEqual(2, len(articles)) + self.assertTrue(all(entry.id == "19252820" for entry in articles)) + self.assertTrue(all(u'Çullu, Quzanlı' in entry.text + for entry in articles)) + self.assertEqual(articles[0].text, u'#REDIRECT [[Çullu, Quzanlı]]') + + self.assertEqual(2, len(talks)) + self.assertTrue(all(entry.id == "19252824" for entry in talks)) + self.assertEqual(talks[1].text, '{{DisambigProject}}') + self.assertEqual(talks[1].comment, 'proj') + + @allowed_failure + def test_edit_summary_decoding(self): + """Test edit summaries are decoded.""" + entries = self._get_entries('pair-0.10.xml', allrevisions=True) + articles = [entry for entry in entries if entry.ns == "0"] + + self.assertEqual(articles[0].comment, + 'moved [[Çullu, Agdam]] to [[Çullu, Quzanlı]]: dab') + + if __name__ == '__main__': try: unittest.main() -- To view, visit https://gerrit.wikimedia.org/r/181713 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82fccdafcf302d77dd3c6c5ce7713e72a4412e5c Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 4 months

Errored: wikimedia/pywikibot-core#1844 (master - 95230ef)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #1844 Status: Errored Duration: 43 minutes and 27 seconds Commit: 95230ef (master) Author: jenkins-bot Message: Merge "Add unit test for isbn script" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/fb5af89cbdb4...95230efd… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/44957005 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

9 years, 4 months

Passed: jayvdb/pywikibot-core#173 (pagegen-ns-name - 62f53e6)

by Travis CI

Build Update for jayvdb/pywikibot-core ------------------------------------- Build: #173 Status: Passed Duration: 40 minutes and 55 seconds Commit: 62f53e6 (pagegen-ns-name) Author: John Vandenberg Message: Allow pagegen filtering using namespace names The ability to filter using namespace names was removed from the isbn script in 31c07b2, but still exists in other scripts. Namespace names are more user-friendly as users interact with these names regularly in titles, while the namespace numbers are less known, especially namespaces which are not frequently used. NamespaceFilterPageGenerator behaviour when site is not provided is modified from 'no validation of namespaces' to 'validation using only the builtin namespaces'. Equality of Namespace(0) with None is no longer supported. Change-Id: Ib6caa11577546e14a69bbd898860843d69d4efb0 View the changeset: https://github.com/jayvdb/pywikibot-core/compare/40eded093856^...62f53e6d21… View the full build log and details: https://travis-ci.org/jayvdb/pywikibot-core/builds/44954963 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

9 years, 4 months

[Gerrit] Add unit test for isbn script - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Add unit test for isbn script ...................................................................... Add unit test for isbn script Bug: T72336 Change-Id: I006570c68e83c52ae5cb0051ad7336eb5e02f93f --- A tests/isbn_tests.py 1 file changed, 127 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/isbn_tests.py b/tests/isbn_tests.py new file mode 100644 index 0000000..cd2c513 --- /dev/null +++ b/tests/isbn_tests.py @@ -0,0 +1,127 @@ +# -*- coding: utf-8 -*- +"""Tests for isbn script.""" +# +# (C) Pywikibot team, 2014 +# +# Distributed under the terms of the MIT license. +# +import pywikibot + +__version__ = '$Id$' + +from scripts.isbn import ISBN10, ISBN13, InvalidIsbnException as IsbnExc, \ + getIsbn, hyphenateIsbnNumbers, convertIsbn10toIsbn13, main +from tests.aspects import TestCase, unittest +from pywikibot import Bot + + +class TestIsbn(TestCase): + + """Test ISBN-related classes and helper functions.""" + + net = False + + def test_isbn10(self): + """Test ISBN10.""" + # Test general features + isbn = ISBN10('097522980x') + isbn.format() + self.assertEqual(isbn.code, '0-9752298-0-X') + self.assertEqual(isbn.digits(), + ['0', '9', '7', '5', '2', '2', '9', '8', '0', 'X']) + + # Converting to ISBN13 + isbn13 = isbn.toISBN13() + self.assertEqual(isbn13.code, '978-0-9752298-0-4') + + # Errors + self.assertRaises(IsbnExc, ISBN10, '0975229LOL') # Invalid characters + self.assertRaises(IsbnExc, ISBN10, '0975229801') # Invalid checksum + self.assertRaises(IsbnExc, ISBN10, '09752298') # Invalid length + self.assertRaises(IsbnExc, ISBN10, '09752X9801') # X in the middle + + def test_isbn13(self): + """Test ISBN13.""" + # Test general features + isbn = ISBN13('9783161484100') + isbn.format() + self.assertEqual(isbn.code, '978-3-16-148410-0') + self.assertEqual(isbn.digits(), + [9, 7, 8, 3, 1, 6, 1, 4, 8, 4, 1, 0, 0]) + isbn = ISBN13('978809027341', checksumMissing=True) + self.assertEqual(isbn.code, '9788090273412') + + # Errors + self.assertRaises(IsbnExc, ISBN13, '9783161484LOL') # Invalid chars + self.assertRaises(IsbnExc, ISBN13, '9783161484105') # Invalid checksum + self.assertRaises(IsbnExc, ISBN13, '9783161484') # Invalid length + + def test_general(self): + """Test things that apply both to ISBN10 and ISBN13.""" + # getIsbn + self.assertIsInstance(getIsbn('097522980x'), ISBN10) + self.assertIsInstance(getIsbn('9783161484100'), ISBN13) + self.assertRaisesRegex(IsbnExc, + 'ISBN-13: The ISBN 097522 is not 13 digits ' + 'long. / ISBN-10: The ISBN 097522 is not 10 ' + 'digits long.', getIsbn, '097522') + + # hyphenateIsbnNumbers + self.assertEqual(hyphenateIsbnNumbers('ISBN 097522980x'), + 'ISBN 0-9752298-0-X') + self.assertEqual(hyphenateIsbnNumbers('ISBN 0975229801'), + 'ISBN 0975229801') # Invalid ISBN - no changes + + # convertIsbn10toIsbn13 + self.assertEqual(convertIsbn10toIsbn13('ISBN 0-9752298-0-X'), + 'ISBN 978-0-9752298-0-4') + self.assertEqual(convertIsbn10toIsbn13('ISBN 0-9752298-0-1'), + 'ISBN 0-9752298-0-1') # Invalid ISBN - no changes + + # Errors + isbn = ISBN10('9492098059') + self.assertRaisesRegex(IsbnExc, + 'ISBN 9492098059: group number unknown.', + isbn.format) + isbn = ISBN10('9095012042') + self.assertRaisesRegex(IsbnExc, + 'ISBN 9095012042: publisher number unknown.', + isbn.format) + + +class TestIsbnBot(TestCase): + + """Test isbnbot with non-write patching (if the testpage exists).""" + + family = 'test' + code = 'test' + + user = True + write = True + + def setUp(self): + self._original_userPut = Bot.userPut + Bot.userPut = userPut_dummy + super(TestIsbnBot, self).setUp() + + def tearDown(self): + Bot.userPut = self._original_userPut + super(TestIsbnBot, self).tearDown() + + def test_isbn(self): + site = self.get_site() + p1 = pywikibot.Page(site, 'User:M4tx/IsbnTest') + # Create the page if it does not exist + if not p1.exists() or p1.text != 'ISBN 097522980x': + p1.text = 'ISBN 097522980x' + p1.save('unit test', botflag=True) + main('-page:User:M4tx/IsbnTest', '-always', '-format', '-to13') + self.assertEqual(self.newtext, 'ISBN 978-0-9752298-0-4') + + +def userPut_dummy(self, page, oldtext, newtext, **kwargs): + TestIsbnBot.newtext = newtext + + +if __name__ == "__main__": + unittest.main() -- To view, visit https://gerrit.wikimedia.org/r/181427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I006570c68e83c52ae5cb0051ad7336eb5e02f93f Gerrit-PatchSet: 6 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: M4tx <m4tx(a)m4tx.pl> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: M4tx <m4tx(a)m4tx.pl> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

9 years, 4 months

Passed: valhallasw/pywikibot-core#40 (master - 13a258e)

by Travis CI

Build Update for valhallasw/pywikibot-core ------------------------------------- Build: #40 Status: Passed Duration: 36 minutes and 57 seconds Commit: 13a258e (master) Author: Merlijn van Deen Message: Allow passing password to Site.login View the changeset: https://github.com/valhallasw/pywikibot-core/compare/3e1457499a94...13a258e… View the full build log and details: https://travis-ci.org/valhallasw/pywikibot-core/builds/44949597 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

9 years, 4 months

Broken: wikimedia/pywikibot-core#1843 (master - fb5af89)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #1843 Status: Broken Duration: 45 minutes and 7 seconds Commit: fb5af89 (master) Author: jenkins-bot Message: Merge "LogeventsPageGenerator: skip problematic entries" View the changeset: https://github.com/wikimedia/pywikibot-core/compare/23c683121b3a...fb5af89c… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/44914099 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

9 years, 4 months

[Gerrit] LogeventsPageGenerator: skip problematic entries - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: LogeventsPageGenerator: skip problematic entries ...................................................................... LogeventsPageGenerator: skip problematic entries If there is an exception while instantiating a Page for a LogEntry, report the error and skip it. Bug: T78152 Change-Id: I2586dbd18b346f8f2f9c78dd6f50d96b2bf6327c --- M pywikibot/pagegenerators.py 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py index 4d3e487..2294b46 100644 --- a/pywikibot/pagegenerators.py +++ b/pywikibot/pagegenerators.py @@ -759,7 +759,13 @@ site = pywikibot.Site() for entry in site.logevents(total=total, logtype=logtype, user=user, namespace=namespace): - yield entry.title() + try: + yield entry.title() + except KeyError as e: + pywikibot.warning(u'LogeventsPageGenerator: ' + u'failed to load page for %r; skipping' + % entry.data) + pywikibot.exception(e) @deprecated("LogeventsPageGenerator") -- To view, visit https://gerrit.wikimedia.org/r/181255 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2586dbd18b346f8f2f9c78dd6f50d96b2bf6327c Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 4 months

Passed: wikimedia/pywikibot-core#1842 (master - 23c6831)

by Travis CI

Build Update for wikimedia/pywikibot-core ------------------------------------- Build: #1842 Status: Passed Duration: 44 minutes and 6 seconds Commit: 23c6831 (master) Author: Fabian Neundorf Message: [FIX] replace: Use correct notation for format When supplying multiple values to format via an iterable (e.g. a tuple) it must be preceded by an asterisk to use each value as a positional value. Change-Id: I5ae457b7f9a9670b4f2c25e42c2ae45e41ea6083 View the changeset: https://github.com/wikimedia/pywikibot-core/compare/812dbd9ea1e3...23c68312… View the full build log and details: https://travis-ci.org/wikimedia/pywikibot-core/builds/44834920 -- You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications

9 years, 4 months

[Gerrit] use the new version of 'archivebot-older-than' - change (pywikibot/compat)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: use the new version of 'archivebot-older-than' ...................................................................... use the new version of 'archivebot-older-than' with the 'duration' parameter per mailing list: http://comments.gmane.org/gmane.comp.python.pywikipediabot.general/14160 corresponding change in the i18n file: I507b0b38a87fe8e97b850a71d9c1764ec16fbeb1 backport of Ie4699550def701a728abaca3e62287e1c36ce3b0 from core Change-Id: Ifefc1c289120edd62747480cee497f846e6810c8 --- M archivebot.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/archivebot.py b/archivebot.py index c4fe7c4..7c80de0 100644 --- a/archivebot.py +++ b/archivebot.py @@ -412,7 +412,9 @@ #return 'unsigned' maxage = str2time(reT.group(1)) if self.now - self.timestamp > maxage: - return message('archivebot-older-than') + ' ' + reT.group(1) + return i18n.twtranslate(Site.language, + 'archivebot-older-than', + {'duration': reT.group(1)}) return '' -- To view, visit https://gerrit.wikimedia.org/r/181407 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifefc1c289120edd62747480cee497f846e6810c8 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Ricordisamoa <ricordisamoa(a)openmailbox.org> Gerrit-Reviewer: jenkins-bot <>

9 years, 4 months

← Newer
1
2
3
4
5
6
7
8
9
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits December 2014