Pywikibot-commits October 2014

pywikibot-commits@lists.wikimedia.org

1 participants
155 discussions

[Gerrit] Revert "@deprecated support for any object" - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: Revert "@deprecated support for any object" ...................................................................... Revert "@deprecated support for any object" This reverts commit c7a414c2a8634705208ff4004ddcc6f5a22a908b. While the change is OK, there are enough problems with the current code that deprecation tests should be committed first, and I have a new version of the deprecators that resolves more of the existing problems, more efficiently. Change-Id: Ib6af8199689b5d4745f3ee2154421bd8e259bbdd --- M pywikibot/tools.py M tests/__init__.py M tests/aspects.py D tests/deprecation_tests.py M tox.ini 5 files changed, 9 insertions(+), 162 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/tools.py b/pywikibot/tools.py index 1d808b7..22e2203 100644 --- a/pywikibot/tools.py +++ b/pywikibot/tools.py @@ -11,7 +11,6 @@ import sys import threading import time -import inspect import re from collections import Mapping from distutils.version import Version @@ -322,34 +321,22 @@ def deprecated(instead=None): - """Decorator to output a deprecation warning. - - A function is assumed to be an instance method when it has a 'self' param - in any position in the arg list, and the first parameter has a class - that is in the same module as the function. + """Decorator to output a method deprecation warning. @param instead: if provided, will be used to specify the replacement @type instead: string """ - def decorator(obj): + def decorator(method): def wrapper(*args, **kwargs): - name = obj.__name__ - if inspect.isfunction(obj): - arg_spec = inspect.getargspec(obj) - if args and 'self' in arg_spec.args: - if args[0].__class__.__module__ == obj.__module__: - name = args[0].__class__.__name__ + '.' + name - elif args and 'cls' in arg_spec.args: - if inspect.isclass(args[0]): - name = args[0].__name__ + '.' + name - name = obj.__module__ + '.' + name + funcname = method.__name__ + classname = args[0].__class__.__name__ if instead: - warning(u"%s is DEPRECATED, use %s instead." % (name, instead)) + warning(u"%s.%s is DEPRECATED, use %s instead." + % (classname, funcname, instead)) else: - warning(u"%s is DEPRECATED." % (name)) - return obj(*args, **kwargs) - wrapper.__name__ = obj.__name__ - wrapper.__doc__ = obj.__doc__ + warning(u"%s.%s is DEPRECATED." % (classname, funcname)) + return method(*args, **kwargs) + wrapper.__name__ = method.__name__ return wrapper return decorator diff --git a/tests/__init__.py b/tests/__init__.py index 4ab2059..b1da838 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -51,7 +51,6 @@ _data_dir = os.path.join(_tests_dir, 'data') library_test_modules = [ - 'deprecation', 'date', 'mediawikiversion', 'ipregex', diff --git a/tests/aspects.py b/tests/aspects.py index 421e426..cbd870c 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -32,7 +32,6 @@ import time import sys import os -import re import pywikibot @@ -658,40 +657,3 @@ pwb = True spawn = True - - -class DeprecationTestCase(TestCase): - - """Test cases for deprecation function in the tools module.""" - - deprecation_messages = [] - - @staticmethod - def _record_messages(msg): - DeprecationTestCase.deprecation_messages.append(msg) - - def assertDeprecationRegex(self, pattern): - for msg in DeprecationTestCase.deprecation_messages: - if re.match(pattern, msg): - return - self.assertIn(pattern, DeprecationTestCase.deprecation_messages) - - def assertDeprecation(self, name): - self.assertDeprecationRegex(name + ' is DEPRECATED.') - - def setUp(self): - self.tools_warning = pywikibot.tools.warning - self.tools_debug = pywikibot.tools.debug - - pywikibot.tools.warning = DeprecationTestCase._record_messages - pywikibot.tools.debug = DeprecationTestCase._record_messages - - super(DeprecationTestCase, self).setUp() - - DeprecationTestCase.deprecation_messages = [] - - def tearDown(self): - pywikibot.tools.warning = self.tools_warning - pywikibot.tools.debug = self.tools_warning - - super(DeprecationTestCase, self).tearDown() diff --git a/tests/deprecation_tests.py b/tests/deprecation_tests.py deleted file mode 100644 index 6fb02ca..0000000 --- a/tests/deprecation_tests.py +++ /dev/null @@ -1,100 +0,0 @@ -# -*- coding: utf-8 -*- -"""Tests for deprecation tools.""" -# -# (C) Pywikibot team, 2014 -# -# Distributed under the terms of the MIT license. -# -__version__ = '$Id$' - -from pywikibot.tools import deprecated -from tests.aspects import unittest, DeprecationTestCase - - -@deprecated() -def deprecated_func(): - """Deprecated function.""" - pass - - -@deprecated() -def deprecated_func_bad_args(self): - """Deprecated function with arg 'self'.""" - pass - - -class DeprecatedMethodClass(object): - - """Class with methods deprecated.""" - - @classmethod - @deprecated() - def class_method(cls): - return cls - - @staticmethod - @deprecated() - def static_method(foo): - return foo - - @deprecated() - def instance_method(self, foo): - self.foo = foo - - def undecorated_method(self): - pass - - -@deprecated() -class DeprecatedClass(object): - - """Deprecated class.""" - - pass - - -class DeprecatorTestCase(DeprecationTestCase): - - """Test cases for deprecation tools.""" - - net = False - - def test_deprecated_function(self): - deprecated_func() - self.assertDeprecation(__name__ + '.deprecated_func') - - def test_deprecated_function_bad_args(self): - deprecated_func_bad_args('a') - self.assertDeprecation(__name__ + '.deprecated_func_bad_args') - - @unittest.expectedFailure - def test_deprecated_function_bad_args_failure(self): - """Test to show the weakness of @deprecated decorator.""" - f = DeprecatedMethodClass() - deprecated_func_bad_args(f) - self.assertDeprecation(__name__ + '.deprecated_func_bad_args') - - def test_deprecated_instance_method(self): - f = DeprecatedMethodClass() - f.instance_method('a') - self.assertDeprecation(__name__ + '.DeprecatedMethodClass.instance_method') - - def test_deprecated_class_method(self): - DeprecatedMethodClass.class_method() - self.assertDeprecation(__name__ + '.DeprecatedMethodClass.class_method') - - def test_deprecated_static_method(self): - DeprecatedMethodClass.static_method('a') - self.assertDeprecation(__name__ + '.static_method') - - def test_deprecate_class(self): - df = DeprecatedClass() - self.assertEqual(df.__doc__, 'Deprecated class.') - self.assertDeprecation(__name__ + '.DeprecatedClass') - - -if __name__ == '__main__': - try: - unittest.main() - except SystemExit: - pass diff --git a/tox.ini b/tox.ini index cd9a7e0..ed4e709 100644 --- a/tox.ini +++ b/tox.ini @@ -57,7 +57,6 @@ ./scripts/illustrate_wikidata.py \ ./scripts/newitem.py \ ./tests/aspects.py \ - ./tests/deprecation_tests.py \ ./tests/api_tests.py \ ./tests/dry_api_tests.py \ ./scripts/maintenance/cache.py \ -- To view, visit https://gerrit.wikimedia.org/r/166278 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6af8199689b5d4745f3ee2154421bd8e259bbdd Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] @deprecated support for any object - change (pywikibot/core)

by XZise (Code Review)

XZise has submitted this change and it was merged. Change subject: @deprecated support for any object ...................................................................... @deprecated support for any object Decorator @deprecated currently assumes it is run on a bound method. If the decorated function doesnt have an argument 'self' or 'cls', fallback to reporting it as a function. Also always report which module the deprecated method is in, as the user may not recognise BaseSite if they are using many packages, and pywikibot might be used indirectly by another package. Change-Id: I24af9784e95e0f57a39dd6523267187ef6a4b8c6 --- M pywikibot/tools.py M tests/__init__.py M tests/aspects.py A tests/deprecation_tests.py M tox.ini 5 files changed, 162 insertions(+), 9 deletions(-) Approvals: XZise: Looks good to me, approved diff --git a/pywikibot/tools.py b/pywikibot/tools.py index 22e2203..1d808b7 100644 --- a/pywikibot/tools.py +++ b/pywikibot/tools.py @@ -11,6 +11,7 @@ import sys import threading import time +import inspect import re from collections import Mapping from distutils.version import Version @@ -321,22 +322,34 @@ def deprecated(instead=None): - """Decorator to output a method deprecation warning. + """Decorator to output a deprecation warning. + + A function is assumed to be an instance method when it has a 'self' param + in any position in the arg list, and the first parameter has a class + that is in the same module as the function. @param instead: if provided, will be used to specify the replacement @type instead: string """ - def decorator(method): + def decorator(obj): def wrapper(*args, **kwargs): - funcname = method.__name__ - classname = args[0].__class__.__name__ + name = obj.__name__ + if inspect.isfunction(obj): + arg_spec = inspect.getargspec(obj) + if args and 'self' in arg_spec.args: + if args[0].__class__.__module__ == obj.__module__: + name = args[0].__class__.__name__ + '.' + name + elif args and 'cls' in arg_spec.args: + if inspect.isclass(args[0]): + name = args[0].__name__ + '.' + name + name = obj.__module__ + '.' + name if instead: - warning(u"%s.%s is DEPRECATED, use %s instead." - % (classname, funcname, instead)) + warning(u"%s is DEPRECATED, use %s instead." % (name, instead)) else: - warning(u"%s.%s is DEPRECATED." % (classname, funcname)) - return method(*args, **kwargs) - wrapper.__name__ = method.__name__ + warning(u"%s is DEPRECATED." % (name)) + return obj(*args, **kwargs) + wrapper.__name__ = obj.__name__ + wrapper.__doc__ = obj.__doc__ return wrapper return decorator diff --git a/tests/__init__.py b/tests/__init__.py index b1da838..4ab2059 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -51,6 +51,7 @@ _data_dir = os.path.join(_tests_dir, 'data') library_test_modules = [ + 'deprecation', 'date', 'mediawikiversion', 'ipregex', diff --git a/tests/aspects.py b/tests/aspects.py index cbd870c..421e426 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -32,6 +32,7 @@ import time import sys import os +import re import pywikibot @@ -657,3 +658,40 @@ pwb = True spawn = True + + +class DeprecationTestCase(TestCase): + + """Test cases for deprecation function in the tools module.""" + + deprecation_messages = [] + + @staticmethod + def _record_messages(msg): + DeprecationTestCase.deprecation_messages.append(msg) + + def assertDeprecationRegex(self, pattern): + for msg in DeprecationTestCase.deprecation_messages: + if re.match(pattern, msg): + return + self.assertIn(pattern, DeprecationTestCase.deprecation_messages) + + def assertDeprecation(self, name): + self.assertDeprecationRegex(name + ' is DEPRECATED.') + + def setUp(self): + self.tools_warning = pywikibot.tools.warning + self.tools_debug = pywikibot.tools.debug + + pywikibot.tools.warning = DeprecationTestCase._record_messages + pywikibot.tools.debug = DeprecationTestCase._record_messages + + super(DeprecationTestCase, self).setUp() + + DeprecationTestCase.deprecation_messages = [] + + def tearDown(self): + pywikibot.tools.warning = self.tools_warning + pywikibot.tools.debug = self.tools_warning + + super(DeprecationTestCase, self).tearDown() diff --git a/tests/deprecation_tests.py b/tests/deprecation_tests.py new file mode 100644 index 0000000..6fb02ca --- /dev/null +++ b/tests/deprecation_tests.py @@ -0,0 +1,100 @@ +# -*- coding: utf-8 -*- +"""Tests for deprecation tools.""" +# +# (C) Pywikibot team, 2014 +# +# Distributed under the terms of the MIT license. +# +__version__ = '$Id$' + +from pywikibot.tools import deprecated +from tests.aspects import unittest, DeprecationTestCase + + +@deprecated() +def deprecated_func(): + """Deprecated function.""" + pass + + +@deprecated() +def deprecated_func_bad_args(self): + """Deprecated function with arg 'self'.""" + pass + + +class DeprecatedMethodClass(object): + + """Class with methods deprecated.""" + + @classmethod + @deprecated() + def class_method(cls): + return cls + + @staticmethod + @deprecated() + def static_method(foo): + return foo + + @deprecated() + def instance_method(self, foo): + self.foo = foo + + def undecorated_method(self): + pass + + +@deprecated() +class DeprecatedClass(object): + + """Deprecated class.""" + + pass + + +class DeprecatorTestCase(DeprecationTestCase): + + """Test cases for deprecation tools.""" + + net = False + + def test_deprecated_function(self): + deprecated_func() + self.assertDeprecation(__name__ + '.deprecated_func') + + def test_deprecated_function_bad_args(self): + deprecated_func_bad_args('a') + self.assertDeprecation(__name__ + '.deprecated_func_bad_args') + + @unittest.expectedFailure + def test_deprecated_function_bad_args_failure(self): + """Test to show the weakness of @deprecated decorator.""" + f = DeprecatedMethodClass() + deprecated_func_bad_args(f) + self.assertDeprecation(__name__ + '.deprecated_func_bad_args') + + def test_deprecated_instance_method(self): + f = DeprecatedMethodClass() + f.instance_method('a') + self.assertDeprecation(__name__ + '.DeprecatedMethodClass.instance_method') + + def test_deprecated_class_method(self): + DeprecatedMethodClass.class_method() + self.assertDeprecation(__name__ + '.DeprecatedMethodClass.class_method') + + def test_deprecated_static_method(self): + DeprecatedMethodClass.static_method('a') + self.assertDeprecation(__name__ + '.static_method') + + def test_deprecate_class(self): + df = DeprecatedClass() + self.assertEqual(df.__doc__, 'Deprecated class.') + self.assertDeprecation(__name__ + '.DeprecatedClass') + + +if __name__ == '__main__': + try: + unittest.main() + except SystemExit: + pass diff --git a/tox.ini b/tox.ini index ed4e709..cd9a7e0 100644 --- a/tox.ini +++ b/tox.ini @@ -57,6 +57,7 @@ ./scripts/illustrate_wikidata.py \ ./scripts/newitem.py \ ./tests/aspects.py \ + ./tests/deprecation_tests.py \ ./tests/api_tests.py \ ./tests/dry_api_tests.py \ ./scripts/maintenance/cache.py \ -- To view, visit https://gerrit.wikimedia.org/r/165971 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24af9784e95e0f57a39dd6523267187ef6a4b8c6 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] update namespace aliases - change (pywikibot/compat)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: update namespace aliases ...................................................................... update namespace aliases Change-Id: I3c1409f22f7db8cd9e5596f61767dd838ac3af26 --- M families/wikipedia_family.py M families/wikivoyage_family.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/families/wikipedia_family.py b/families/wikipedia_family.py index f79d9a6..8b0533c 100644 --- a/families/wikipedia_family.py +++ b/families/wikipedia_family.py @@ -56,10 +56,10 @@ self.namespaces[7]['be'] = [u'Размовы пра файл', u'Размовы пра выяву'] self.namespaces[2]['ckb'] = [u'بەکارھێنەر', u'U', u'ب'] self.namespaces[3]['ckb'] = [u'لێدوانی بەکارھێنەر', u'UT', u'قسەی بەکارھێنەر', u'لب'] - self.namespaces[8]['ckb'] = [u'میدیاویکی', u'MW', u'مو'] + self.namespaces[8]['ckb'] = [u'میدیاویکی', u'مو'] self.namespaces[10]['ckb'] = [u'داڕێژە', u'T', u'د', u'قاڵب'] self.namespaces[12]['ckb'] = [u'یارمەتی', u'H', u'ی'] - self.namespaces[14]['ckb'] = [u'پۆل', u'C', u'پ'] + self.namespaces[14]['ckb'] = [u'پۆل', u'پ'] self.namespaces[2]['cs'] = [u'Wikipedista', u'Uživatel', u'Wikipedistka'] self.namespaces[3]['de'] = [u'Benutzer Diskussion', u'BD', u'Benutzerin Diskussion'] self.namespaces[12]['de'] = [u'Hilfe', u'H'] @@ -1047,6 +1047,7 @@ self.namespaces[446] = { 'ar': u'برنامج التعليم', + 'ca': u'Education Program', 'cs': u'Education Program', 'el': u'Education Program', 'en': u'Education Program', @@ -1062,6 +1063,7 @@ self.namespaces[447] = { 'ar': u'نقاش برنامج التعليم', + 'ca': u'Education Program talk', 'cs': u'Education Program talk', 'el': u'Education Program talk', 'en': u'Education Program talk', diff --git a/families/wikivoyage_family.py b/families/wikivoyage_family.py index c17a95d..e5e1834 100644 --- a/families/wikivoyage_family.py +++ b/families/wikivoyage_family.py @@ -29,6 +29,8 @@ self.namespaces[3]['de'] = [u'Benutzer Diskussion', u'BD', u'Benutzerin Diskussion'] self.namespaces[12]['de'] = [u'Hilfe', u'H'] self.namespaces[13]['de'] = [u'Hilfe Diskussion', u'HD'] + self.namespaces[2]['fa'] = [u'کاربر'] + self.namespaces[3]['fa'] = [u'بحث کاربر'] self.namespaces[3]['fr'] = [u'Discussion utilisateur', u'Discussion Utilisateur', u'Discussion utilisatrice'] self.namespaces[2]['pl'] = [u'Użytkownik', u'Użytkowniczka'] self.namespaces[3]['pl'] = [u'Dyskusja użytkownika', u'Dyskusja użytkowniczki'] -- To view, visit https://gerrit.wikimedia.org/r/166192 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c1409f22f7db8cd9e5596f61767dd838ac3af26 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/compat Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] category.py: consider also /doc subpages in template ns - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: category.py: consider also /doc subpages in template ns ...................................................................... category.py: consider also /doc subpages in template ns For templates, categories can be in /doc subpage. Added the check of the /doc page as well. Modified: - textlib.removeDisabledParts() - textlib.getCategoryLinks() - page.change_category() to optionally consider also categories in tags otherwise removed. Also Pep257 fixes in textlib.py Bug: 55017 Change-Id: I8faecb5f0de75c0f9b635815c6a73ac367bfb2f1 --- M pywikibot/page.py M pywikibot/textlib.py M scripts/category.py 3 files changed, 33 insertions(+), 14 deletions(-) Approvals: John Vandenberg: Looks good to me, approved Mpaa: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 7c1d9d3..013afd4 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -1669,7 +1669,7 @@ return self.site.protect(self, protections, reason, **kwargs) def change_category(self, oldCat, newCat, comment=None, sortKey=None, - inPlace=True): + inPlace=True, include=[]): """ Remove page from oldCat and add it to newCat. @@ -1683,17 +1683,21 @@ @param inPlace: if True, change categories in place rather than rearranging them. + + @param include: list of tags not to be disabled by default in relevant + textlib functions, where CategoryLinks can be searched. + @type: list + @return: True if page was saved changed, otherwise False. """ # get list of Category objects the article is in and remove possible # duplicates cats = [] - for cat in textlib.getCategoryLinks(self.text, site=self.site): + for cat in textlib.getCategoryLinks(self.text, site=self.site, + include=include): if cat not in cats: cats.append(cat) - - site = self.site if not sortKey: sortKey = oldCat.sortKey @@ -1718,7 +1722,7 @@ site=self.site) else: if newCat: - cats[cats.index(oldCat)] = Category(site, newCat.title(), + cats[cats.index(oldCat)] = Category(self.site, newCat.title(), sortKey=sortKey) else: cats.pop(cats.index(oldCat)) diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 4b3934b..f4e4f0d 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -273,7 +273,7 @@ return text -def removeDisabledParts(text, tags=['*']): +def removeDisabledParts(text, tags=['*'], include=[]): """ Return text without portions where wiki markup is disabled. @@ -284,7 +284,9 @@ * includeonly tags The exact set of parts which should be removed can be passed as the - 'parts' parameter, which defaults to all. + 'tags' parameter, which defaults to all. + Or, in alternative, default parts that shall not be removed can be + specified in the 'include' param. """ regexes = { @@ -298,7 +300,7 @@ if '*' in tags: tags = list(regexes.keys()) # add alias - tags = set(tags) + tags = set(tags) - set(include) if 'source' in tags: tags.add('syntaxhighlight') toRemoveR = re.compile('|'.join([regexes[tag] for tag in tags]), @@ -659,8 +661,12 @@ # Functions dealing with category links # ------------------------------------- -def getCategoryLinks(text, site=None): +def getCategoryLinks(text, site=None, include=[]): """Return a list of category links found in text. + + @param include: list of tags which should not be removed by + removeDisabledParts() and where CategoryLinks can be searched. + @type: list @return: all category links found @rtype: list of Category objects @@ -670,7 +676,7 @@ site = pywikibot.Site() # Ignore category links within nowiki tags, pre tags, includeonly tags, # and HTML comments - text = removeDisabledParts(text) + text = removeDisabledParts(text, include=include) catNamespace = '|'.join(site.category_namespaces()) R = re.compile(r'\[\[\s*(?P<namespace>%s)\s*:\s*(?P<rest>.+?)\]\]' % catNamespace, re.I) @@ -1130,7 +1136,7 @@ def does_text_contain_section(pagetext, section): """ - Determines whether the page text contains the given section title. + Determine whether the page text contains the given section title. @param pagetext: The wikitext of a page @type text: unicode or string @@ -1187,9 +1193,7 @@ class TimeStripper(object): - """ - Find timestamp in page and return it as timezone aware datetime object. - """ + """Find timestamp in page and return it as timezone aware datetime object.""" def __init__(self, site=None): if site is None: diff --git a/scripts/category.py b/scripts/category.py index 12beae3..ddc5665 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -634,10 +634,21 @@ for page in pagegenerators.PreloadingGenerator(gen): if not self.title_regex or re.search(self.title_regex, page.title()): + page.change_category(self.oldcat, self.newcat, comment=self.comment, inPlace=self.inplace) + # Categories for templates can be included in <includeonly> section + # of Template:X/doc subpage. + if page.namespace() == 10: + doc_page = pywikibot.Page(page.site, page.title() + '/doc') + if doc_page.exists(): + doc_page.change_category(self.oldcat, self.newcat, + comment=self.comment, + inPlace=self.inplace, + include=['includeonly']) + @staticmethod def check_move(name, old_page, new_page): """Return if the old page can be safely moved to the new page.""" -- To view, visit https://gerrit.wikimedia.org/r/164782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8faecb5f0de75c0f9b635815c6a73ac367bfb2f1 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] [FEAT] Category: AddCategory renamed to CategoryAddBot and i... - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FEAT] Category: AddCategory renamed to CategoryAddBot and inherits Bot ...................................................................... [FEAT] Category: AddCategory renamed to CategoryAddBot and inherits Bot Change-Id: I26c253c308cdd0f70b417fc36b619ccc1978c1c6 --- M scripts/category.py 1 file changed, 48 insertions(+), 103 deletions(-) Approvals: Mpaa: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/category.py b/scripts/category.py index 12beae3..3afc3a4 100755 --- a/scripts/category.py +++ b/scripts/category.py @@ -112,9 +112,10 @@ import sys import pywikibot +from pywikibot import Bot from pywikibot import config, pagegenerators from pywikibot import i18n, textlib -from pywikibot.tools import deprecate_arg, deprecated +from pywikibot.tools import deprecate_arg, deprecated, ModuleDeprecationWrapper if sys.version_info[0] > 2: basestring = (str, ) @@ -264,21 +265,21 @@ % config.shortpath(filename)) -class AddCategory: +class CategoryAddBot(Bot): """A robot to mass-add a category to a list of pages.""" @deprecate_arg('editSummary', 'comment') + @deprecate_arg('dry', None) def __init__(self, generator, newcat=None, sort_by_last_name=False, - create=False, comment='', follow_redirects=False, - dry=False): + create=False, comment='', follow_redirects=False): + super(CategoryAddBot, self).__init__() self.generator = generator self.newcat = newcat self.sort = sort_by_last_name self.create = create self.follow_redirects = follow_redirects self.always = False - self.dry = dry self.comment = comment def sorted_by_last_name(self, catlink, pagelink): @@ -301,133 +302,74 @@ match_object = bracketsR.match(page_name) if match_object: page_name = match_object.group(1) - split_string = page_name.split(' ') + split_string = page_name.rsplit(' ', 1) if len(split_string) > 1: # pull last part of the name to the beginning, and append the # rest after a comma; e.g., "John von Neumann" becomes # "Neumann, John von" - sorted_key = split_string[-1] + ', ' + ' '.join(split_string[:-1]) + sorted_key = split_string[1] + ', ' + split_string[0] # give explicit sort key return pywikibot.Page(site, catlink.title() + '|' + sorted_key) else: return pywikibot.Page(site, catlink.title()) - - def run(self): - counter = 0 - for page in self.generator: - self.treat(page) - counter += 1 - pywikibot.output(u"%d page(s) processed." % counter) - - def load(self, page): - """Load the given page's content. - - If page doesn't exists returns an empty string. - """ - try: - # Load the page - text = page.text - except pywikibot.NoPage: - if self.create: - pywikibot.output(u"Page %s doesn't exist yet; creating." - % (page.title(asLink=True))) - return '' - else: - pywikibot.output(u"Page %s does not exist; skipping." - % page.title(asLink=True)) - else: - return text - - def save(self, text, page, newcat, minorEdit=True, botflag=True, old_text=None): - if old_text is None: - old_text = self.load(page) - # only save if something was changed - if text != old_text: - # show what was changed - pywikibot.showDiff(old_text, text) - comment = self.comment - if not comment: - comment = i18n.twtranslate(page.site, 'category-adding', - {'newcat': newcat}) - pywikibot.output(u'Comment: %s' % comment) - if not self.dry: - if not self.always: - confirm = 'y' - while True: - choice = pywikibot.inputChoice( - u'Do you want to accept these changes?', - ['Yes', 'No', 'Always'], ['y', 'N', 'a'], 'N') - if choice == 'a': - confirm = pywikibot.inputChoice(u"""\ -This should be used if and only if you are sure that your links are correct! -Are you sure?""", ['Yes', 'No'], ['y', 'n'], 'n') - if confirm == 'y': - self.always = True - break - else: - break - if self.always or choice == 'y': - try: - # Save the page - page.put(text, comment=comment, - minorEdit=minorEdit, botflag=botflag) - except pywikibot.LockedPage: - pywikibot.output(u"Page %s is locked; skipping." - % page.title(asLink=True)) - except pywikibot.EditConflict: - pywikibot.output( - u'Skipping %s because of edit conflict' - % (page.title())) - except pywikibot.SpamfilterError as error: - pywikibot.output( - u'Cannot change %s because of spam blacklist entry ' - u'%s' % (page.title(), error.url)) - else: - return True - return False def treat(self, page): if page.isRedirectPage(): # if it's a redirect use the redirect target instead redirTarget = page.getRedirectTarget() if self.follow_redirects: - page = redirTarget + self.current_page = redirTarget else: pywikibot.warning(u"Page %s is a redirect to %s; skipping." % (page.title(asLink=True), redirTarget.title(asLink=True))) # loading it will throw an error if we don't jump out before return - text = self.load(page) - if text is None: + else: + self.current_page = page + if self.current_page.exists(): + # Load the page + text = self.current_page.text + elif self.create: + pywikibot.output(u"Page %s doesn't exist yet; creating." + % (self.current_page.title(asLink=True))) + text = '' + else: + pywikibot.output(u"Page %s does not exist; skipping." + % self.current_page.title(asLink=True)) return # store old text, so we don't have reload it every time old_text = text cats = textlib.getCategoryLinks(text) - # Show the title of the page we're working on. - # Highlight the title in purple. - pywikibot.output( - u"\n\n>>> \03{lightpurple}%s\03{default} <<<" - % page.title()) pywikibot.output(u"Current categories:") for cat in cats: pywikibot.output(u"* %s" % cat.title()) newcat = self.newcat - if not page.site.nocapitalize: + if not self.current_page.site.nocapitalize: newcat = newcat[:1].upper() + newcat[1:] - catpl = pywikibot.Page(page.site, newcat, ns=14) + catpl = pywikibot.Page(self.current_page.site, newcat, ns=14) if catpl in cats: pywikibot.output(u"%s is already in %s." - % (page.title(), catpl.title())) + % (self.current_page.title(), catpl.title())) else: if self.sort: - catpl = self.sorted_by_last_name(catpl, page) + catpl = self.sorted_by_last_name(catpl, self.current_page) pywikibot.output(u'Adding %s' % catpl.title(asLink=True)) cats.append(catpl) - text = textlib.replaceCategoryLinks(text, cats, site=page.site) - if not self.save(text, page, newcat, old_text=old_text): - pywikibot.output(u'Page %s not saved.' - % page.title(asLink=True)) + text = textlib.replaceCategoryLinks(text, cats, + site=self.current_page.site) + comment = self.comment + if not comment: + comment = i18n.twtranslate(self.current_page.site, + 'category-adding', + {'newcat': newcat}) + try: + self.userPut(self.current_page, old_text, text, + comment=comment, minor=True, botflag=True) + except pywikibot.PageSaveRelatedError as error: + pywikibot.output(u'Page %s not saved: %s' + % (self.current_page.title(asLink=True), + error)) class CategoryMoveRobot(object): @@ -1179,12 +1121,12 @@ # The preloading generator is responsible for downloading multiple # pages from the wiki simultaneously. gen = pagegenerators.PreloadingGenerator(gen) - bot = AddCategory(gen, - newcat=newCatTitle, - sort_by_last_name=sort_by_last_name, - create=create_pages, - comment=editSummary, - follow_redirects=follow_redirects) + bot = CategoryAddBot(gen, + newcat=newCatTitle, + sort_by_last_name=sort_by_last_name, + create=create_pages, + comment=editSummary, + follow_redirects=follow_redirects) elif action == 'remove': if not fromGiven: oldCatTitle = pywikibot.input(u'Please enter the name of the ' @@ -1259,3 +1201,6 @@ if __name__ == "__main__": main() + +wrapper = ModuleDeprecationWrapper(__name__) +wrapper._add_deprecated_attr('AddCategory', CategoryAddBot) -- To view, visit https://gerrit.wikimedia.org/r/161130 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26c253c308cdd0f70b417fc36b619ccc1978c1c6 Gerrit-PatchSet: 6 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] Update test order - change (pywikibot/core)

by XZise (Code Review)

XZise has submitted this change and it was merged. Change subject: Update test order ...................................................................... Update test order - perform python 3 tests before python 2.6 - add new test modules to tests/__init__ module ordering Change-Id: If97017df6845afd937325c969ec42d034219f114 --- M .travis.yml M tests/__init__.py 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: XZise: Looks good to me, approved diff --git a/.travis.yml b/.travis.yml index 013a1b9..fe58fc3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,8 +2,8 @@ python: - '2.7' - - '2.6' - '3.3' + - '2.6' before_install: - sudo apt-get update -qq diff --git a/tests/__init__.py b/tests/__init__.py index b1da838..9331544 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -61,9 +61,13 @@ 'dry_api', 'dry_site', 'api', + 'family', 'site', + 'link', + 'interwiki_link', 'page', 'file', + 'edit_failure', 'timestripper', 'pagegenerators', 'wikidataquery', @@ -71,12 +75,15 @@ 'i18n', 'ui', 'wikibase', + 'wikibase_edit', + 'upload', ] script_test_modules = [ 'pwb', 'script', 'archivebot', + 'data_ingestion', ] disabled_test_modules = [ -- To view, visit https://gerrit.wikimedia.org/r/163789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If97017df6845afd937325c969ec42d034219f114 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] Remove references to wikipedia.py - change (pywikibot/core)

by XZise (Code Review)

XZise has submitted this change and it was merged. Change subject: Remove references to wikipedia.py ...................................................................... Remove references to wikipedia.py Change-Id: Ibf5eaaf153c5b7edae23779bdaba95e8b519a548 --- M generate_user_files.py M pywikibot/config2.py M pywikibot/exceptions.py M pywikibot/textlib.py M pywikibot/version.py 5 files changed, 7 insertions(+), 10 deletions(-) Approvals: XZise: Looks good to me, approved diff --git a/generate_user_files.py b/generate_user_files.py index 0043dcb..8a99806 100644 --- a/generate_user_files.py +++ b/generate_user_files.py @@ -338,12 +338,12 @@ if pywikibot.inputChoice( "Do you want to copy user files from an existing Pywikibot " "installation?", ["yes", "no"], ["y", "n"]) == "y": - oldpath = pywikibot.input("Path to existing wikipedia.py?") + oldpath = pywikibot.input("Path to existing user-config.py?") if not os.path.exists(oldpath): pywikibot.error("Not a valid path") continue if os.path.isfile(oldpath): - # User probably typed /wikipedia.py at the end, so strip it + # User probably typed /user-config.py at the end, so strip it oldpath = os.path.dirname(oldpath) if not os.path.isfile(os.path.join(oldpath, "user-config.py")): pywikibot.error("No user_config.py found in that directory") diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 0ad9bc7..ac8d1a4 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -44,9 +44,9 @@ # ############# ACCOUNT SETTINGS ############## -# The family of sites we are working on. wikipedia.py will import +# The family of sites we are working on. pywikibot will import # families/xxx_family.py so if you want to change this variable, -# you need to write such a file. +# you need to write such a file if one does not exist. family = 'wikipedia' # The language code of the site we're working on. mylang = 'language' @@ -128,7 +128,7 @@ # edit summary to use if not supplied by bot script # WARNING: this should NEVER be used in practice, ALWAYS supply a more # relevant summary for bot edits -default_edit_summary = u'Wikipedia python library v.2' +default_edit_summary = u'Pywikibot v.2' def get_base_dir(test_directory=None): diff --git a/pywikibot/exceptions.py b/pywikibot/exceptions.py index fec58df..f99c0b6 100644 --- a/pywikibot/exceptions.py +++ b/pywikibot/exceptions.py @@ -51,9 +51,6 @@ from pywikibot.tools import UnicodeMixin -# TODO: These are copied from wikipedia.py; not certain that all of them -# will be needed in the rewrite. - class Error(UnicodeMixin, Exception): diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 4b3934b..1efcafd 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -1040,7 +1040,7 @@ if not name or name.startswith('#'): continue -# TODO: merged from wikipedia.py - implement the following +# TODO: implement the following; 'self' and site dont exist in this function # if self.site().isInterwikiLink(name): # continue # # {{DEFAULTSORT:...}} diff --git a/pywikibot/version.py b/pywikibot/version.py index 1002ffb..7e232a1 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -82,7 +82,7 @@ except: # nothing worked; version unknown (but suppress exceptions) # the value is most likely '$Id' + '$', it means that - # wikipedia.py got imported without using svn at all + # pywikibot was imported without using version control at all. return dict(tag='', rev='-1 (unknown)', date='0 (unknown)', hsh='(unknown)') -- To view, visit https://gerrit.wikimedia.org/r/165740 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf5eaaf153c5b7edae23779bdaba95e8b519a548 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] [FEAT] config2: Allow to test whether a path would work - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: [FEAT] config2: Allow to test whether a path would work ...................................................................... [FEAT] config2: Allow to test whether a path would work The config2 now also allows to "simulate" that a specific base directory does exist, to get rid of the warning when the user doesn't has to do anything to make it find the user-config.py. Change-Id: I88691ea634f0579aa28ee88d852d9073283c4ae7 --- M generate_user_files.py M pywikibot/config2.py 2 files changed, 34 insertions(+), 21 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/generate_user_files.py b/generate_user_files.py index 05df8f0..0043dcb 100644 --- a/generate_user_files.py +++ b/generate_user_files.py @@ -86,6 +86,9 @@ pywikibot.output("Created new directory.") break + if new_base == pywikibot.config2.get_base_dir(new_base): + # config would find that file + return new_base from textwrap import wrap msg = wrap(u"""WARNING: Your user files will be created in the directory '%(new_base)s' you have chosen. To access these files, you will either have diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 0b04b5a..0ad9bc7 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -131,7 +131,7 @@ default_edit_summary = u'Wikipedia python library v.2' -def _get_base_dir(): +def get_base_dir(test_directory=None): r"""Return the directory in which user-specific information is stored. This is determined in the following order - @@ -147,7 +147,20 @@ Set PYWIKIBOT2_NO_USER_CONFIG=1 to disable loading user-config.py + @param test_directory: Assume that a user config file exists in this + directory. Used to test whether placing a user config file in this + directory will cause it to be selected as the base directory. + @type test_directory: str or None """ + def exists(directory): + directory = os.path.abspath(directory) + if directory == test_directory: + return True + else: + return os.path.exists(os.path.join(directory, 'user-config.py')) + + if test_directory is not None: + test_directory = os.path.abspath(test_directory) NAME = "pywikibot" base_dir = "" for arg in sys.argv[1:]: @@ -155,24 +168,22 @@ base_dir = arg[5:] sys.argv.remove(arg) break - current_exists = os.path.exists( - os.path.join(os.path.abspath("."), "user-config.py")) - if current_exists and "PYWIKIBOT2_DIR" not in os.environ and not base_dir: - base_dir = os.path.abspath(".") - return base_dir else: - if "PYWIKIBOT2_DIR" in os.environ: - base_dir = os.environ["PYWIKIBOT2_DIR"] - elif not base_dir: - is_windows = sys.platform == 'win32' + if 'PYWIKIBOT2_DIR' in os.environ: + base_dir = os.environ['PYWIKIBOT2_DIR'] + elif exists('.'): + return os.path.abspath('.') + else: home = os.path.expanduser("~") - if is_windows: + if sys.platform == 'win32': import platform - _win_version = int(platform.version()[0]) - if _win_version == 5: + win_version = int(platform.version()[0]) + if win_version == 5: base_dir = os.path.join(home, "Application Data", NAME) - elif _win_version == 6: + elif win_version == 6: base_dir = os.path.join(home, "AppData\\Roaming", NAME) + #TODO: Throw exception otherwise to notify the user that the + # version of Windows is not (yet) supported else: base_dir = os.path.join(home, "." + NAME) if not os.path.isdir(base_dir): @@ -181,22 +192,21 @@ base_dir = os.path.normpath(os.path.join(os.getcwd(), base_dir)) # make sure this path is valid and that it contains user-config file if not os.path.isdir(base_dir): - raise RuntimeError("Directory '%(base_dir)s' does not exist." - % locals()) - if not os.path.exists(os.path.join(base_dir, "user-config.py")): - exc_text = ("No user-config.py found in directory '%(base_dir)s'.\n" - % locals()) + raise RuntimeError("Directory '%s' does not exist." % base_dir) + if not exists(base_dir): + exc_text = "No user-config.py found in directory '%s'.\n" % base_dir if os.environ.get('PYWIKIBOT2_NO_USER_CONFIG', '0') == '1': print(exc_text) else: exc_text += " Please check that user-config.py is stored in the correct location.\n" exc_text += " Directory where user-config.py is searched is determined as follows:\n\n" - exc_text += " " + _get_base_dir.__doc__ + exc_text += " " + get_base_dir.__doc__ raise RuntimeError(exc_text) return base_dir -_base_dir = _get_base_dir() +_get_base_dir = get_base_dir # for backward compatibility +_base_dir = get_base_dir() # Save base_dir for use by other modules base_dir = _base_dir -- To view, visit https://gerrit.wikimedia.org/r/165651 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88691ea634f0579aa28ee88d852d9073283c4ae7 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] Remove unnecessary setUp and tearDown - change (pywikibot/core)

by XZise (Code Review)

XZise has submitted this change and it was merged. Change subject: Remove unnecessary setUp and tearDown ...................................................................... Remove unnecessary setUp and tearDown Change-Id: Ie3bc71d6b60ceab9057b2ac030041c8a847f02f6 --- M tests/family_tests.py 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: XZise: Looks good to me, approved diff --git a/tests/family_tests.py b/tests/family_tests.py index 1115d91..be281aa 100644 --- a/tests/family_tests.py +++ b/tests/family_tests.py @@ -22,12 +22,6 @@ net = False - def setUp(self): - super(TestCase, self).setUp() - - def tearDown(self): - super(TestCase, self).tearDown() - def test_eq_different_families_by_name(self): """Test that two Family with same name are equal.""" family_1 = Family() -- To view, visit https://gerrit.wikimedia.org/r/165709 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3bc71d6b60ceab9057b2ac030041c8a847f02f6 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

[Gerrit] update mw version - change (pywikibot/core)

by jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. Change subject: update mw version ...................................................................... update mw version Change-Id: I18dc02845b9aaa49092cb4a22110c67d9a15a15a --- M pywikibot/family.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/family.py b/pywikibot/family.py index 8941078..6f5a7bc 100644 --- a/pywikibot/family.py +++ b/pywikibot/family.py @@ -1046,7 +1046,7 @@ Use L{pywikibot.tools.MediaWikiVersion} to compare version strings. """ # Here we return the latest mw release for downloading - return '1.23.2' + return '1.23.5' @deprecated("version()") def versionnumber(self, code): -- To view, visit https://gerrit.wikimedia.org/r/165702 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18dc02845b9aaa49092cb4a22110c67d9a15a15a Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot <>

9 years, 7 months

← Newer
1
...
9
10
11
12
13
14
15
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Pywikibot-commits October 2014