Delete button on gerrit - Cloud-admin

Bryan Davis

5 Mar 5 Mar

8:09 p.m.

On Mon, Mar 5, 2018 at 1:00 PM, Jaime Crespo <jcrespo(a)wikimedia.org> wrote:

I just been told there is now a delete button, DON'T USE IT- I just pressed it by mistake after entering in edit mode thinking it was a "discard patch started on web interface" (but it is very easy to pres it by mistake), and apparently it removes the entire CR. I was told by Paladox this is a new feature on gerrit, and I do not like it already. I managed to delete the work of a workmate. :-( I could restore everthing from the database backups, but as it also deletes the git files content, it doesn't work without it -it cannot be reverted- only text can be recover from the database in not the nicest formatting. Apologies for the damages caused. Should I file a ticket to propose to disable such a button from the UI?

That does seem like a horrible feature to have readily accessible in the gerrit UI. I'd +1 work to disable/hide it. Bryan -- Bryan Davis Wikimedia Foundation <bd808(a)wikimedia.org> [[m:User:BDavis_(WMF)]] Manager, Cloud Services Boise, ID USA irc: bd808 v:415.839.6885 x6855

Reply

Ian Marlier

8:22 p.m.

New subject: [Ops] Delete button on gerrit

If you happen to have an adblocker installed, you can add the delete button to the blocked elements list until it's addressed globally. On Mon, Mar 5, 2018 at 3:12 PM, Chase Pettet <cpettet(a)wikimedia.org> wrote:

...

It seems potentially the only time to use it would be an accidental leak of sensitive info in a changeset, and you would still want to change the leaked value. More than once I have discovered an abandoned change from someone and learned a lesson so that seems like the superior everyday mechanism for "not useful" anymore :) On Mar 5, 2018 2:00 PM, "Jaime Crespo" <jcrespo(a)wikimedia.org> wrote:

I just been told there is now a delete button, DON'T USE IT- I just pressed it by mistake after entering in edit mode thinking it was a "discard patch started on web interface" (but it is very easy to pres it by mistake), and apparently it removes the entire CR. I was told by Paladox this is a new feature on gerrit, and I do not like it already. I managed to delete the work of a workmate. :-( I could restore everthing from the database backups, but as it also deletes the git files content, it doesn't work without it -it cannot be reverted- only text can be recover from the database in not the nicest formatting. Apologies for the damages caused. Should I file a ticket to propose to disable such a button from the UI? -- Jaime Crespo <http://wikimedia.org> _______________________________________________ Cloud-admin mailing list Cloud-admin(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/cloud-admin

_______________________________________________ Ops mailing list Ops(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/ops

Reply

Chad Horohoe

6 Mar 6 Mar

12:36 a.m.

New subject: [Ops] Delete button on gerrit

On Mon, Mar 5, 2018 at 12:01 PM Jaime Crespo <jcrespo(a)wikimedia.org> wrote:

...

I just been told there is now a delete button, DON'T USE IT- I just pressed it by mistake after entering in edit mode thinking it was a "discard patch started on web interface" (but it is very easy to pres it by mistake), and apparently it removes the entire CR. I was told by Paladox this is a new feature on gerrit, and I do not like it already. I managed to delete the work of a workmate. :-( I could restore everthing from the database backups, but as it also deletes the git files content, it doesn't work without it -it cannot be reverted- only text can be recover from the database in not the nicest formatting. Apologies for the damages caused. Should I file a ticket to propose to disable such a button from the UI?

Sooooo, this is supposed to be "Delete Own Changes" but I suppose if you took control of a change (via adding your patch set to the CR) it would result in you deleting others' changes. That's a *horrible* privilege escalation! No need for a ticket, I've disabled this. -Chad

Reply